An enhancement for IMM to print out 5 last FEVS events into syslog
when IMMND down for any reason.
---
src/imm/Makefile.am | 4 +-
src/imm/common/immsv_evt.c | 2 +-
src/imm/common/immsv_evt.h | 1 +
src/imm/immnd/immnd_evt.c| 6 ++
src/imm/immnd/immnd_utils.cc | 200
Hi Danh,
Ack with minor comments.
Regards, Vu
> -Original Message-
> From: Danh Vo
> Sent: Wednesday, August 1, 2018 3:29 PM
> To: hans.nordeb...@ericsson.com; lennart.l...@ericsson.com;
> gary@dektech.com.au; vu.m.ngu...@dektech.com.au
> Cc: opensaf-devel@lists.sourceforge.net;
Hi Danh Vo
I have checked the new version. All my comments (also the ones in the previous
diff file) except spreading the log feature over several files are still valid.
You should however still put all the new log code in a new file and use C++.
Small C functions in that file can be used in
Hi Lennart,
I have just pushed a new version of this ticket based on Vu Minh Nguyen
comments.
It would be nice if you take your time to review the new one.
But I still consider your comments of the old version for adapting into the
new one if it is necessary.
Thank you in advance!
Best regards,
Hi Danh Vo
Most of my comments can be found in the attached .diff file. This diff can be
applied on top of the review branch
A summary of my comments:
Do not add a feature as code distributed in several files and functions not
related to the feature. Keep the feature in in one file and
An enhancement for IMM to print out 5 last FEVS events into syslog when
IMMND down for any reason.
---
src/imm/common/immsv_evt.c | 2 +-
src/imm/common/immsv_evt.h | 1 +
src/imm/immnd/immnd_evt.c | 209 -
3 files changed, 208 insertions(+), 4
Thanks a.Vu for comments!
I will push another version for this ticket soon.
Best regards,
Danh Vo
-Original Message-
From: Vu Minh Nguyen
Sent: Monday, July 30, 2018 11:07 AM
To: 'Danh Vo' ; hans.nordeb...@ericsson.com;
lennart.l...@ericsson.com; gary@dektech.com.au
Cc:
Hi Danh,
1) Move all added new functions into immnd_evt.c.
2) Some more comments are inline.
Regards, Vu
> -Original Message-
> From: Danh Vo
> Sent: Friday, July 27, 2018 11:46 AM
> To: hans.nordeb...@ericsson.com; lennart.l...@ericsson.com;
> gary@dektech.com.au;
An enhancement for IMM to print out 5 last FEVS events into syslog when
IMMND down for any reason.
---
src/imm/common/immsv_evt.c | 2 +-
src/imm/common/immsv_evt.h | 2 +
src/imm/immnd/ImmModel.cc | 285 +
src/imm/immnd/ImmModel.h | 1 +
