Re: [devel] [PATCH 1/1] mds: Add Reset message [#3090]

2019-10-14 Thread Tran Thuan
Hi bro.Minh, Thanks, no more comment from me. Best Regards, ThuanTr -Original Message- From: Minh Hon Chau Sent: Monday, October 14, 2019 7:28 PM To: Tran Thuan ; hans.nordeb...@ericsson.com; gary@dektech.com.au; vu.m.ngu...@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net S

Re: [devel] [PATCH 1/1] mds: Add Reset message [#3090]

2019-10-14 Thread Minh Hon Chau
Hi Thuan, I can rename it as "Intro" message, then the rcvwnd counter shall be removed. This new message can not replace the tx prob timer. This new message is to speed up the determinatin of flow control at the peer side rather than mds data message. It is needed for the flow control sender

Re: [devel] [PATCH 1/1] mds: Add Reset message [#3090]

2019-10-14 Thread Tran Thuan
Hi bro.Minh, Thanks for explanation. I think the "reset" message should be rename to "introduce" message. Another question: with this fix, will tx probation timer become redundant or still useful in somehow? Best Regards, ThuanTr -Original Message- From: Minh Hon Chau Sent: Monday, Oc

Re: [devel] [PATCH 1/1] mds: Add Reset message [#3090]

2019-10-13 Thread Minh Hon Chau
Hi Thuan, If the chunkack is configured to send after a few data messages, then the sender is not getting any chunkack for the first message from receiver until chunkack timeout (which is also configurable to be a bit larger value). Then, the probation timer would be timeout at sender. The r

Re: [devel] [PATCH 1/1] mds: Add Reset message [#3090]

2019-10-13 Thread Tran Thuan
Hi bro.Minh, - In my understanding, tx probation timer only start when sender send first message. Then sender relies on chunkAck to know receiver support MDS FCTRL or timeout as not support. But from what you describe, sender got tx probation timer timeout before sending first message? Or after se

[devel] [PATCH 1/1] mds: Add Reset message [#3090]

2019-10-10 Thread Minh Chau
mds relies on data message sent from the peer to determine whether the MDS_TIPC_FCTRL_ENABLED is set. The data message may not be sent right after TIPC_PUBLISHED event, which can cause the tx probation timer timeout. This patch add Reset message, which is sent right after the TIPC_PUBLISHED to hel