Re: [devel] [PATCH 1/1] mds: Disable mds flow control for mds broadcast/multicast message [#3101]

2019-10-20 Thread Minh Hon Chau
Hi Thuan, The patch is acked and I pushed it. The commit message may cause you a missundestanding, but in this context it does not mention anything regarding to configuration, so I hope it's ok. Another comment inline. Thanks Minh On 21/10/19 1:56 pm, Tran Thuan wrote: Hi Minh, I

Re: [devel] [PATCH 1/1] mds: Disable mds flow control for mds broadcast/multicast message [#3101]

2019-10-20 Thread Tran Thuan
Hi Minh, I suggest commit message as following mds: skip flow control for bcast/mcast message if tipc multicast enabled. because "disable mds flow control" cause misunderstood overwrite configure MDS_TIPC_FCTRL_ENABLED And another comment with [Thuan] inline. Thanks. Best Regards,

Re: [devel] [PATCH 1/1] mds: Disable mds flow control for mds broadcast/multicast message [#3101]

2019-10-20 Thread Gary Lee
Hi Minh ack (review only) Thanks On 17/10/19 2:00 pm, Minh Chau wrote: The mds flow control has been disabled for broadcast/mulitcast unfragment message if tipc multicast is enabled. This patch revisits and continues with fragment messages. --- src/mds/mds_tipc_fctrl_intf.cc | 47

[devel] [PATCH 1/1] mds: Disable mds flow control for mds broadcast/multicast message [#3101]

2019-10-16 Thread Minh Chau
The mds flow control has been disabled for broadcast/mulitcast unfragment message if tipc multicast is enabled. This patch revisits and continues with fragment messages. --- src/mds/mds_tipc_fctrl_intf.cc | 47 src/mds/mds_tipc_fctrl_msg.h | 11