ack, review only. /Thanks HansN
On 03/27/2018 10:34 AM, Hoa Le wrote:
- Remove thread-local declaration of svc_to_mds_info
---
src/mds/apitest/mdstipc_api.c | 7 ++-
src/mds/apitest/mdstipc_conf.c | 43 +-
2 files changed, 27 insertions(+), 23
Hi Hans,
In version 2 of the patch, I have removed the thread-local declaration
of svc_to_mds_info as your suggestion and use it as local variable for
each MDS service request to avoid Data race issues.
Please help review it again.
Thank you.
--
Best regards,
Hoa Le
On 03/27/2018 01:41 PM,
- Remove thread-local declaration of svc_to_mds_info
---
src/mds/apitest/mdstipc_api.c | 7 ++-
src/mds/apitest/mdstipc_conf.c | 43 +-
2 files changed, 27 insertions(+), 23 deletions(-)
diff --git a/src/mds/apitest/mdstipc_api.c
Hi Hoa,
Do we need the svc_to_mds_info to be tls? I used it in the sample added to
ticket
to reduce number of helgrind warnings when I verified safe_printf and
safe_fflush.
It should have been removed in the sample, as it was not fully verified.
/Thanks HansN
-Original Message-
- Use __thread if _Thread_local is not supported in GCC version lower than 4.9
---
src/mds/apitest/mdstipc.h | 6 ++
src/mds/apitest/mdstipc_api.c | 2 +-
src/mds/apitest/mdstipc_conf.c | 2 +-
3 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/mds/apitest/mdstipc.h
