Hi Minh,
Please see my responses inline.
In general, I am trying to implement new version to reuse exist database.
Best Regards,
ThuanTr
From: Minh Hon Chau
Sent: Wednesday, October 23, 2019 12:23 PM
To: Tran Thuan ; 'Nguyen Minh Vu'
; hans.nordeb...@ericsson.com;
Hi Thuan,
Please see comment inline
Thanks
Minh
On 23/10/19 3:32 pm, Tran Thuan wrote:
Hi Minh,
Thanks for comments. See my response inline.
Btw, I am preparing to send out new patch, I think I found an issue in
current patch.
Best Regards,
ThuanTr
-Original Message-
From:
Hi Minh,
Thanks for comments. See my response inline.
Btw, I am preparing to send out new patch, I think I found an issue in current
patch.
Best Regards,
ThuanTr
-Original Message-
From: Minh Hon Chau
Sent: Wednesday, October 23, 2019 5:52 AM
To: Tran Thuan ; 'Nguyen Minh
Hi Thuan,
I wonder the patch would work in the same reproduced steps if the both
adests have subscribed each other more than 2 services. The svc_cnt will
be greater than 1 until it is the last service down event. I think
that's why mds has the database @subtn_results, in which each item is an
Hi Vu,
Thanks for additional comments.
I reply your concerns inline below.
Best Regards,
ThuanTr
-Original Message-
From: Nguyen Minh Vu
Sent: Tuesday, October 22, 2019 5:28 PM
To: thuan.tran ; 'Minh Chau'
; hans.nordeb...@ericsson.com; gary@dektech.com.au
Cc:
Hi Thuan,
I have additional comments below.
Regards, Vu
On 10/22/19 7:14 AM, thuan.tran wrote:
- When sending response message which Adest not exist (already down)
current MDS try to wait for 1.5 seconds before conclude no route to
send response message.
- There are 2 scenarios may have:
UP
Hi Vu,
Thanks for comments. I reply my answer inline.
Best Regards,
ThuanTr
-Original Message-
From: Nguyen Minh Vu
Sent: Tuesday, October 22, 2019 4:42 PM
To: thuan.tran ; 'Minh Chau'
; hans.nordeb...@ericsson.com; gary@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net
Hi Thuan,
I have few comments below.
Regards, Vu
On 10/22/19 7:14 AM, thuan.tran wrote:
- When sending response message which Adest not exist (already down)
current MDS try to wait for 1.5 seconds before conclude no route to
send response message.
- There are 2 scenarios may have:
UP -> DOWN
Hi Minh,
Thanks for your comments:
1- The wait time 1.5 in this flow:
mds_mcm_process_disc_queue_checks_redundant()
mds_subtn_tbl_add_disc_queue()
if (true == time_wait) {
timeout_val = 150; /* This may need a tuning */
}
2- We should not touch to current adest
Hi Thuan,
1- Can you point out where is the mds code that waits for 1.5 seconds,
is it hard coded within 1.5 secs?
2- Is existing db (mds_c_db.c) in mds not enough so we need to introduce
adest_list? I think mds must have a memory of adest, perhaps in another
implicit form, so mds can
- When sending response message which Adest not exist (already down)
current MDS try to wait for 1.5 seconds before conclude no route to
send response message.
- There are 2 scenarios may have:
UP -> DOWN -> receive SNDRSP -> response timeout after 1.5s
UP -> receive SNDRSP -> DOWN -> response
Hi,
There is a issue with this change, I need consider more.
Please ignore this review for now.
Best Regards,
ThuanTr
-Original Message-
From: thuan.tran
Sent: Thursday, October 17, 2019 4:56 PM
To: 'Minh Chau' ; hans.nordeb...@ericsson.com;
gary@dektech.com.au;
- When sending response message which Adest not exist (already down)
current MDS try to waiting in 1.5 seconds before conclude no route to
send response message.
- With this change, MDS will not waste for 1.5s which can cause trouble
for higher layer services, e.g: ntf, imm, etc...
---
13 matches
Mail list logo
