Re: [devel] [PATCH 1/1] pyosaf: refactor IMM utils [#2683]

Many thanks Hans. Regards, Hieu -Original Message- From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com] Sent: Tuesday, January 9, 2018 10:27 PM To: Hieu Thanh Nguyen ; Anders Widell ; srinivas.mangip...@oracle.com Cc:

Re: [devel] [PATCH 1/1] pyosaf: refactor IMM utils [#2683]

Hi Hieu, Nice work, the changes looks fine./Thanks HansN -Original Message- From: Hieu Nguyen [mailto:hieu.t.ngu...@dektech.com.au] Sent: den 9 januari 2018 12:26 To: Hans Nordebäck ; Anders Widell ; srinivas.mangip...@oracle.com

Re: [devel] [PATCH 1/1] pyosaf: refactor IMM utils [#2683]

Hi Hieu, ack, code review only/Thanks HansN On 01/09/2018 12:17 PM, Hieu Nguyen wrote: + improve OI utils use a separate instance OM agent + refactor OM utils with Ccb inheritace OmAgent, rename some classes... --- python/Makefile.am | 1 +

[devel] [PATCH 1/1] pyosaf: refactor IMM utils [#2683]

+ improve OI utils use a separate instance OM agent + refactor OM utils with Ccb inheritace OmAgent, rename some classes... --- python/Makefile.am | 1 + python/pyosaf/utils/immoi/__init__.py| 465 +- python/pyosaf/utils/immoi/agent.py

Re: [devel] [PATCH 1/1] pyosaf: refactor IMM utils [#2683]

Hi Hieu, it sounds good. The question about backwards compatible was to highlight possible application problems, it should not be too hard to avoid this non backward compatibility, either as you suggest, changing version, or perhaps, with some overhead, do the init if needed in each

Re: [devel] [PATCH 1/1] pyosaf: refactor IMM utils [#2683]

Thanks Hans, New exception is just an improvement to make exception type and message clearer. It informs ERR_INIT to user so that user knows that OI needs to be initialized before any function is used. Something like that: >>> from pyosaf.utils import immoi >>>

Re: [devel] [PATCH 1/1] pyosaf: refactor IMM utils [#2683]

Hi Hieu, Yes, I noticed that e.g. initialize is needed, but also other changes e.g. new exceptions are thrown. These changes implies that applications may have to be updated and thus the changes are not backwards compatible. /Regards HansN -Original Message- From: Hieu Nguyen

Re: [devel] [PATCH 1/1] pyosaf: refactor IMM utils [#2683]

Hi Hans, I answered your questions below: Q: " These changes are not backwards compatible ?" A: These change still support pyosaf utils old version. Your sample missing immoi.initialize() before, correctly: python >>> from pyosaf.utils import immoi >>> immoi.initialize() >>>

Re: [devel] [PATCH 1/1] pyosaf: refactor IMM utils [#2683]

Hi Hieu, I have some initial questions regarding this patch: These changes are not backwards compatible, e.g.:     python     >>> from pyosaf.utils import immoi     >>> immoi.get_available_classes_in_imm() do not work after this patch. Why is some behavior changed in e.g. functions marked

Re: [devel] [PATCH 1/1] pyosaf: refactor IMM utils [#2683]

Hi Hans, Anders and Srinivas, Happy new year !!! I wish you will be healthy and happiness in 2018. I already answered Hans's question, how can I test for this patch. Please spend a little time help me review for this patch. Ticket-2681

[devel] [PATCH 1/1] pyosaf: refactor IMM utils [#2683]

+ improve OI utils use a separate instance OM agent + refactor OM utils with Ccb inheritace OmAgent, rename some classes... --- python/Makefile.am | 1 + python/pyosaf/utils/immoi/__init__.py| 531 +++ python/pyosaf/utils/immoi/agent.py

Re: [devel] [PATCH 1/1] pyosaf: refactor IMM utils [#2683]

Hi Hieu, before I start reviewing, a question, how has this patch been tested? /Regards HansN On 12/19/2017 06:17 AM, Hieu Nguyen wrote: + improve OI utils use a separate instance OM agent + refactor OM utils with Ccb inheritace OmAgent, rename some classes... ---

[devel] [PATCH 1/1] pyosaf: refactor IMM utils [#2683]

+ improve OI utils use a separate instance OM agent + refactor OM utils with Ccb inheritace OmAgent, rename some classes... --- python/pyosaf/utils/immoi/__init__.py| 531 +++ python/pyosaf/utils/immoi/agent.py | 473 +++

Re: [devel] [PATCH 1/1] pyosaf: refactor IMM utils [#2683]

Hi Hans, Anders & Srinivas, Just reminding. Please spend a little time to help me review this patch. Many thanks, Hieu -Original Message- From: Hieu Nguyen [mailto:hieu.t.ngu...@dektech.com.au] Sent: Wednesday, December 6, 2017 2:46 PM To: hans.nordeb...@ericsson.com;

[devel] [PATCH 1/1] pyosaf: refactor IMM utils [#2683]

+ improve OI utils use a separate instance OM agent + refactor OM utils with Ccb inheritace OmAgent, rename some classes... --- python/pyosaf/utils/immoi/__init__.py| 531 +++ python/pyosaf/utils/immoi/agent.py | 473 +++