Hi Thuan,
Ack from me.
Thanks,
Nagendra, 91-9866424860
www.hasolutions.in
https://www.linkedin.com/company/hasolutions/
High Availability Solutions Pvt. Ltd.
- OpenSAF Support and Services
- Original Message - Subject: [PATCH 1/1] smf: Increase
;
lennart.l...@ericsson.com; gary@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 1/1] smf: Increase cbk count before post the evt
to client [#2882]
Hi Nagu,
Thanks for your comment.
If m_NCS_IPC_SEND fails, smfa_cbk_ok_resp_process() is called to free
Hi Thuan,
Ack from me.
Just a suggestion for more correct comment (in case there's only one
handle matching the callback label):
/* Descrease the cbk count */ => /* Remove the agent hdl from the cbk_list */
Thanks,
Nguyen
On 7/13/2018 10:52 AM, thuan.tran wrote:
Sometimes, callback agent
Hi Nagu,
Thanks for your comment.
If m_NCS_IPC_SEND fails, smfa_cbk_ok_resp_process() is called to free memory.
Best Regards,
Thuan
From: nagen...@hasolutions.in
Sent: Friday, July 13, 2018 9:29 PM
To: thuan.tran ; nguyen.tk@dektech.com.au;
lennart.l...@ericsson.com;
Hi Thuan,
Nice work. Ack from me.
It would be nice if the memory allocated above in the function need to be
deallocated if m_NCS_IPC_SEND fails.
Thanks,
Nagendra, 91-9866424860
www.hasolutions.in
https://www.linkedin.com/company/hasolutions/
High Availability Solutions Pvt.
Tran Thuan ; lennart.l...@ericsson.com;
Gary Lee
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 1/1] smf: Increase cbk count before post
the evt to client [#2882]
Hi Thuan,
I think it's not a good idea and also not that critical to crash the SMF client
just because of the age
ubject: Re: [devel] [PATCH 1/1] smf: Increase cbk count before post the evt to
client [#2882]
Hi,
A failed calloc() breaks the main flow and intended purpose of the function,
and perhaps the original author saw no better way to gracefully handle and
signify the failure except to assert. I
...@ericsson.com; Gary Lee
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 1/1] smf: Increase cbk count before post the evt to
client [#2882]
Hi Thuan,
I think it's not a good idea and also not that critical to crash the SMF client
just because of the agent failing to send a callback
EK VietNam
>
> -Original Message-
> From: Nguyen Luu
> Sent: Wednesday, July 4, 2018 5:08 PM
> To: thuan.tran ; lennart.l...@ericsson.com
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: Re: [devel] [PATCH 1/1] smf: Increase cbk count before post
> the evt to
, July 4, 2018 5:08 PM
To: thuan.tran ; lennart.l...@ericsson.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 1/1] smf: Increase cbk count before post the evt to
client [#2882]
Hi,
One comment from me for the patch: With the new flow, the matched hdl should be
removed from
Subject: Re: [devel] [PATCH 1/1] smf: Increase cbk count before post the evt to
client [#2882]
Hi,
One comment from me for the patch: With the new flow, the matched hdl should be
removed from the cbk_list if posting the message to the client mailbox fails.
A general comment: The original issue
Hi,
One comment from me for the patch: With the new flow, the matched hdl
should be removed from the cbk_list if posting the message to the client
mailbox fails.
A general comment: The original issue happened because of a race
condition in which the smfa_cb was used in different threads
Sometimes, callback agent dispatch and fail at saSmfReponse()
because cbk list is empty, agent by somehow handle evt before increase
cbk count. To avoid this, increase cbk count before post the evt.
---
src/smf/agent/smfa_utils.c | 38 --
1 file changed, 20
13 matches
Mail list logo
