Re: [devel] [PATCH 1/1] smf: Validation error for rollback CCB and a related core dump [#2858]

2018-06-07 Thread Nguyen Luu
Hi Lennart, If you think the flag will be useful later, then it's good to keep it as is. Then there's no more comment from me. Thanks, Nguyen On 6/7/2018 6:22 PM, Lennart Lund wrote: Hi Nguyen, It is correct that it is not used in SMF any longer. However the CCB handler is generic and

Re: [devel] [PATCH 1/1] smf: Validation error for rollback CCB and a related core dump [#2858]

2018-06-07 Thread Lennart Lund
Hi Nguyen, It is correct that it is not used in SMF any longer. However the CCB handler is generic and could in the future be moved to become OpenSAF common code and the possibility to ignore if an object to be created already exist may be useful. The only reason why it could not be used in

Re: [devel] [PATCH 1/1] smf: Validation error for rollback CCB and a related core dump [#2858]

2018-06-06 Thread Nguyen Luu
Hi Lennart, Ack from me for this new patch. Code review only, no re-test. Just a minor comment below for you to consider. Since we will now not add the CreateDescriptor for an object to the CCB if it already exists (CheckObjectExist::IsExisting() == CheckObjectExist::ReturnCode::kOk), do we

[devel] [PATCH 1/1] smf: Validation error for rollback CCB and a related core dump [#2858]

2018-06-05 Thread Lennart Lund
SMF imm operation lists may contain duplicate create operations. Fix, rollback data shall not be stored for duplicate operations and duplicate operations shall not be added to the CCB. Fix, crash in SmfUtil::doImmoperation if the CCB fails --- opensaf.spec.in | 3

[devel] [PATCH 1/1] smf: Validation error for rollback CCB and a related core dump [#2858]

2018-05-29 Thread Lennart Lund
SMF imm operation lists may contain duplicate create operations. Fix, rollback data shall not be stored for duplicate operations and duplicate operations shall not be added to the CCB. Fix, crash in SmfUtil::doImmoperation if the CCB fails --- opensaf.spec.in | 3