Re: [devel] [PATCH 1/2] base: Add support to direct OpenSAF logging to local node file [#2306]

sekhar.ko...@oracle.com *Kopia:* opensaf-devel@lists.sourceforge.net *Ämne:* Re: [devel] [PATCH 1/2] base: Add support to direct OpenSAF logging to local node file [#2306] Hi Minh, yes, before this patch logtrace.h was a c header file callable from c and c++. Now it is a c/c++ header file so inclu

Re: [devel] [PATCH 1/2] base: Add support to direct OpenSAF logging to local node file [#2306]

t; *Skickat:* den 18 april 2018 20:43:22 *Till:* Minh Hon Chau; Anders Widell; ravisekhar.ko...@oracle.com *Kopia:* opensaf-devel@lists.sourceforge.net *Ämne:* Re: [devel] [PATCH 1/2] base: Add support to direct OpenSAF logging to local node file [#2306] Hi Minh, yes, before this patch logtrace.h was

Re: [devel] [PATCH 1/2] base: Add support to direct OpenSAF logging to local node file [#2306]

complete header file. /Thanks HansN Från: Hans Nordebäck <hans.nordeb...@ericsson.com> Skickat: den 18 april 2018 20:43:22 Till: Minh Hon Chau; Anders Widell; ravisekhar.ko...@oracle.com Kopia: opensaf-devel@lists.sourceforge.net Ämne: Re: [devel] [PATCH 1/2]

Re: [devel] [PATCH 1/2] base: Add support to direct OpenSAF logging to local node file [#2306]

Hi Minh, yes, before this patch logtrace.h was a c header file callable from c and c++. Now it is a c/c++ header file so including it from a c program without the extern "c++" will fail. In the first review comment I suggested to move this part to a separate header file and keep logtrace.h

Re: [devel] [PATCH 1/2] base: Add support to direct OpenSAF logging to local node file [#2306]

Hi Hans, One comment regarding extern C++ as below Thanks, Minh On 18/04/18 23:37, Hans Nordebäck wrote: Hi Minh, See my comments below. /Thanks HansN -Original Message- From: Minh Hon Chau [mailto:minh.c...@dektech.com.au] Sent: den 18 april 2018 15:20 To: Hans Nordebäck

Re: [devel] [PATCH 1/2] base: Add support to direct OpenSAF logging to local node file [#2306]

Hi Minh, See my comments below. /Thanks HansN -Original Message- From: Minh Hon Chau [mailto:minh.c...@dektech.com.au] Sent: den 18 april 2018 15:20 To: Hans Nordebäck ; Anders Widell ; ravisekhar.ko...@oracle.com Cc:

Re: [devel] [PATCH 1/2] base: Add support to direct OpenSAF logging to local node file [#2306]

Hi Hans, Please check my response with [Minh] Thanks Minh On 18/04/18 22:40, Hans Nordeback wrote: Hi Minh, ack, code review only. Some comments below. /Thanks HansN On 04/12/2018 01:12 AM, Minh Chau wrote: Unify TraceLog and MdsLog class to one class (TraceLog) so it can be used as a

Re: [devel] [PATCH 1/2] base: Add support to direct OpenSAF logging to local node file [#2306]

Hi Minh, ack, code review only. Some comments below. /Thanks HansN On 04/12/2018 01:12 AM, Minh Chau wrote: Unify TraceLog and MdsLog class to one class (TraceLog) so it can be used as a common log client. Add new instance TraceLog for OpenSAF logging to local file, which can be

Re: [devel] [PATCH 1/2] base: Add support to direct OpenSAF logging to local node file [#2306]

Hi, If you have time, can you please review the patch? I have done self review, a few things I think it needs to update - The redundant headers file in mds_log.cc that were needed for MdsLog class should be removed - The TraceLog::Init needs to return if the Init() has been already done. -

[devel] [PATCH 1/2] base: Add support to direct OpenSAF logging to local node file [#2306]

Unify TraceLog and MdsLog class to one class (TraceLog) so it can be used as a common log client. Add new instance TraceLog for OpenSAF logging to local file, which can be enabled/disabled via environment variable OSAF_LOCAL_NODE_LOG --- src/base/logtrace.cc | 167