Re: [devel] [PATCH 1 of 1] AMFND: errors reported by valgrind [#716]

2014-01-22 Thread Hans Feldt
* The short commit message should describe what the patch is doing * Wherever free is used instead of delete a comment should added explaining why * Do not add error handling for out of memory errors, in case of malloc just do osafassert(p != NULL); Hans N: any comments? Thanks, HansF On 13

Re: [devel] [PATCH 1 of 1] AMFND: errors reported by valgrind [#716]

2014-01-22 Thread Hans Nordebäck
ack, I have only done code review and I think it looks ok, the comment malloc'ed in avsv_edp_susi_asgn() in sidb.cc is correct I guess but I couldn't directly find the related malloc. /BR HansN -Original Message- From: Gary Lee [mailto:gary@dektech.com.au] Sent: den 13 januari

[devel] [PATCH 1 of 1] AMFND: errors reported by valgrind [#716]

2014-01-13 Thread Gary Lee
osaf/services/saf/amf/amfnd/amfnd.cc|4 +- osaf/services/saf/amf/amfnd/cbq.cc |4 +- osaf/services/saf/amf/amfnd/ckpt_updt.cc|4 +- osaf/services/saf/amf/amfnd/comp.cc | 14 +- osaf/services/saf/amf/amfnd/compdb.cc |6 +-