Re: [devel] [PATCH 1 of 1] amfd: Don't send alarm SI has no current active assignments if node is locked V2 [#1465]

Hi Hans N, Ack with the following comment. > But I think safer is do these assignments(si->si_on_node = su->su_on_node; > si->curr_su = su;) in the 'if condition' for Mw NoRed. > Anyway, it gets overwritten when next SUSI is created with same SI. > Also, No Red SI is not

Re: [devel] [PATCH 1 of 1] amfd: Don't send alarm SI has no current active assignments if node is locked V2 [#1465]

Hi Hans N, I tested with combination of SU/Node lock/locked-in with pres state inst fail/term fail. So, when node is locked/locked-in, even if su goes into term fail, the alarm is not sent because the pres state becomes uninst before update_ass_state gets called. Hope this is ok. Ack with the

Re: [devel] [PATCH 1 of 1] amfd: Don't send alarm SI has no current active assignments if node is locked V2 [#1465]

Forgot to provide comments in the previous email. Please find comments inlined with [Nagu]. Thanks -Nagu > -Original Message- > From: Nagendra Kumar > Sent: 10 September 2015 15:58 > To: Hans Nordeback; Praveen Malviya; gary@dektech.com.au > Cc: opensaf-devel@lists.sourceforge.net >

Re: [devel] [PATCH 1 of 1] amfd: Don't send alarm SI has no current active assignments if node is locked V2 [#1465]

Hi Nagu, please see comment below. /Thanks HansN On 09/10/2015 12:30 PM, Nagendra Kumar wrote: > Forgot to provide comments in the previous email. Please find comments > inlined with [Nagu]. > > Thanks > -Nagu >> -Original Message- >> From: Nagendra Kumar >> Sent: 10 September 2015

Re: [devel] [PATCH 1 of 1] amfd: Don't send alarm SI has no current active assignments if node is locked V2 [#1465]

Hi Nagu, Please see comment inlined/Thanks HansN -Original Message- From: Nagendra Kumar [mailto:nagendr...@oracle.com] Sent: den 10 september 2015 13:04 To: Hans Nordebäck; Praveen Malviya; Gary Lee Cc: opensaf-devel@lists.sourceforge.net Subject: RE: [devel] [PATCH 1 of 1] amfd: Don't

Re: [devel] [PATCH 1 of 1] amfd: Don't send alarm SI has no current active assignments if node is locked V2 [#1465]

Hi Nagu, you mean the patch is acked and it can be pushed? /Thanks HansN On 09/10/2015 01:40 PM, Nagendra Kumar wrote: > Hi Hans N, > Comments inlined. > > Thanks > -Nagu > >> -Original Message- >> From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com] >> Sent: 10

Re: [devel] [PATCH 1 of 1] amfd: Don't send alarm SI has no current active assignments if node is locked V2 [#1465]

Hi Hans N, Please find comment inlined. Thanks -Nagu > -Original Message- > From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com] > Sent: 10 September 2015 16:17 > To: Nagendra Kumar; Praveen Malviya; gary@dektech.com.au > Cc: opensaf-devel@lists.sourceforge.net > Subject:

Re: [devel] [PATCH 1 of 1] amfd: Don't send alarm SI has no current active assignments if node is locked V2 [#1465]

Hi Hans N, Comments inlined. Thanks -Nagu > -Original Message- > From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com] > Sent: 10 September 2015 16:54 > To: Nagendra Kumar; Praveen Malviya; Gary Lee > Cc: opensaf-devel@lists.sourceforge.net > Subject: RE: [devel]