Re: [devel] [PATCH 1 of 1] amfd: Ensure HA state notification is sent when a SI is first assigned to a SU [#544]

2014-03-25 Thread Hans Feldt
Hi, Nack because we get redundant system stream entries with this change. I think the log in the same function that you changed should be removed. Logging will be done from avd_gen_su_ha_state_changed_ntf The commit message is a bit long, why not just amfd: send notification when SI first

Re: [devel] [PATCH 1 of 1] amfd: Ensure HA state notification is sent when a SI is first assigned to a SU [#544]

2014-03-25 Thread Gary Lee
Hi Hans Thanks, I missed the redundant log entry. I thought the same with regards to the commit message, after sending the review request :) Please change and push for me. Thanks Gary On 25/03/14 17:05, Hans Feldt wrote: Hi, Nack because we get redundant system stream entries with this

[devel] [PATCH 1 of 1] amfd: Ensure HA state notification is sent when a SI is first assigned to a SU [#544]

2014-02-27 Thread Gary Lee
osaf/services/saf/amf/amfd/siass.cc | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/osaf/services/saf/amf/amfd/siass.cc b/osaf/services/saf/amf/amfd/siass.cc --- a/osaf/services/saf/amf/amfd/siass.cc +++ b/osaf/services/saf/amf/amfd/siass.cc @@ -259,6 +259,7 @@