Re: [devel] [PATCH 1 of 1] amfd: Respond with TRY_AGAIN to admin ops during a controller switch-over [#821]

2014-04-23 Thread Nagendra Kumar
Hi Gary, Tested : 1. amf-adm lock safVersion=4.0.0,safAppType=OpenSafApplicationType Got error: Admin operation not supported for safVersion=4.0.0,safAppType=OpenSafApplicationType 2. amf-adm si-swap safSi=SC-2N,safApp=OpenSAF and then amf-adm lock safSu=SC-1\,safSg=2N\,safApp=OpenSAF Apr 23

Re: [devel] [PATCH 1 of 1] amfd: Respond with TRY_AGAIN to admin ops during a controller switch-over [#821]

2014-04-22 Thread Nagendra Kumar
Few comments: 1. report_admin_op_error could be used instead of avd_saImmOiAdminOperationResult stating appropriate reason. 2. The below code should be removed now from avd_sg_2n_siswap_func: if (susi-si-sg_of_si-sg_ncs_spec) { if (true == avd_cb-swap_switch ) {

Re: [devel] [PATCH 1 of 1] amfd: Respond with TRY_AGAIN to admin ops during a controller switch-over [#821]

2014-04-22 Thread Gary Lee
Thanks Nagendra... I'm wondering if we should convert report_admin_op_error to use the job queue as well. Though it's less likely 'users' will be querying IMM immediately after an admin op fails, in contrast with the success case. Thanks Gary On 22/04/14 20:13, Nagendra Kumar wrote: Few

[devel] [PATCH 1 of 1] amfd: Respond with TRY_AGAIN to admin ops during a controller switch-over [#821]

2014-04-21 Thread Gary Lee
osaf/services/saf/amf/amfd/imm.cc | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) It has been found that an admin operation (other than controller switch-over) can be started after a controller switch-over has been initiated. The result of this can be that the admin