Re: [devel] [PATCH 1 of 1] amfd: convert avnd_ng_tag to a class [#1142]

2015-02-10 Thread praveen malviya
Ack (code review only). Thanks, Praveen On 09-Feb-15 11:54 AM, gary@dektech.com.au wrote: osaf/services/saf/amf/amfd/include/node.h | 19 +-- osaf/services/saf/amf/amfd/node.cc| 5 ++ osaf/services/saf/amf/amfd/nodegroup.cc | 73 +++---

Re: [devel] [PATCH 1 of 1] amfd: convert avnd_ng_tag to a class [#1142]

2015-02-09 Thread Hans Nordebäck
It looks ok to me, code review only. One comment, saAmfNGNodeList is now ordered, (by std::string) before it was unordered, so perhaps the comment in su.cc:482 should be updated? /Thanks HansN On 02/09/2015 07:24 AM, gary@dektech.com.au wrote: osaf/services/saf/amf/amfd/include/node.h |

[devel] [PATCH 1 of 1] amfd: convert avnd_ng_tag to a class [#1142]

2015-02-08 Thread gary . lee
osaf/services/saf/amf/amfd/include/node.h | 19 +-- osaf/services/saf/amf/amfd/node.cc| 5 ++ osaf/services/saf/amf/amfd/nodegroup.cc | 73 +++--- osaf/services/saf/amf/amfd/sg.cc | 14 ++--- osaf/services/saf/amf/amfd/su.cc | 42