Thanks Lennart,
I will add this before pushing code.
Regards,
Canh.
-Original Message-
From: Lennart Lund [mailto:lennart.l...@ericsson.com]
Sent: Tuesday, October 11, 2016 8:51 PM
To: Canh Van Truong; Vu Minh Nguyen; mahesh.va...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Hi Canh,
ACK .
-AVM
On 9/1/2016 12:22 PM, Canh Truong wrote:
> Hi Mahesh,
>
> I run cppcheck with latest version 1.75. I got from:
> https://sourceforge.net/projects/cppcheck/files/cppcheck/1.75/
> And build, then run with option --enable=performance.
>
> Regards,
> Canh.
>
> -Original
Hi Canh,
Ack with comment
1)
Why not initialize all variables in the structs in initialization list? At
least for the lists where some variables are. More consistent
Example:
struct file_communicate {
bool request_f; /* True if pending request */
bool answer_f; /* True if pending answer */
Hi Mahesh,
I run cppcheck with latest version 1.75. I got from:
https://sourceforge.net/projects/cppcheck/files/cppcheck/1.75/
And build, then run with option --enable=performance.
Regards,
Canh.
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: Thursday,
Hi Canh Van Truong,
Can you please share the suggestion reported by cppcheck.
-AVM
On 8/31/2016 2:19 PM, Canh Van Truong wrote:
> osaf/services/saf/logsv/lgs/lgs_config.cc | 35
> --
> osaf/services/saf/logsv/lgs/lgs_file.cc | 4 +-
> 2 files changed,
osaf/services/saf/logsv/lgs/lgs_config.cc | 35 --
osaf/services/saf/logsv/lgs/lgs_file.cc | 4 +-
2 files changed, 16 insertions(+), 23 deletions(-)
Fix performance reported by cppcheck.
diff --git a/osaf/services/saf/logsv/lgs/lgs_config.cc
