Re: [devel] [PATCH 1 of 1] log: implement SaLogFilterSetCallbackT [#2146]

Hi Lennart, Thanks for your comments. As I understand you mean that the agent shall send to the server with the minor version that is initialized with client [in minor version] , except if minor = 0, it will be set to 1. But as section of 3.5.1 AIS document " minorVersion = highest value of

Re: [devel] [PATCH 1 of 1] log: implement SaLogFilterSetCallbackT [#2146]

Hi Canh One more thing: The Log PR document must be updated. Filter callback is now supported, version handling is changed and minor version 3 must be set if callback shall be used Thanks Lennart > -Original Message- > From: Canh Van Truong [mailto:canh.v.tru...@dektech.com.au] > Sent:

Re: [devel] [PATCH 1 of 1] log: implement SaLogFilterSetCallbackT [#2146]

Hi Canh See my comments inline [Lennart] Thanks Lennart > -Original Message- > From: Canh Van Truong [mailto:canh.v.tru...@dektech.com.au] > Sent: den 1 januari 2017 13:27 > To: Lennart Lund ; Vu Minh Nguyen > ;

[devel] [PATCH 1 of 1] log: implement SaLogFilterSetCallbackT [#2146]

src/log/agent/lga.h |3 + src/log/agent/lga_api.c |2 +- src/log/agent/lga_mds.c | 70 + src/log/agent/lga_util.c | 60 - src/log/apitest/logtest.c |2 +-

Re: [devel] [PATCH 1 of 1] log: implement SaLogFilterSetCallbackT [#2146]

Hi Canh Some more comments about version handling and optimization of sending callback data: 1. I think that minor version has to be increased to 3 (2 is already used for CLM handling). The reason is that it must be possible for a client to get information if filter callback is supported 2.

Re: [devel] [PATCH 1 of 1] log: implement SaLogFilterSetCallbackT [#2146]

Hi Canh, I have some comments: - API version handling (minor version) is a bit questionable. Maybe Mahesh CLM handling should get an "official" version 2 (is somewhat hidden as is) and version 3 to be used for the callback addition. I think there is a possibility that someone will set version

Re: [devel] [PATCH 1 of 1] log: implement SaLogFilterSetCallbackT [#2146]

Hi Lennart, I already did the upgrade test as your below and it was passed from my side. I will check and run all test again Regards, Canh -Original Message- From: Lennart Lund [mailto:lennart.l...@ericsson.com] Sent: Tuesday, November 15, 2016 11:16 PM To: Canh Van Truong; Vu Minh

Re: [devel] [PATCH 1 of 1] log: implement SaLogFilterSetCallbackT [#2146]

Hi Canh I have done some testing and have found problems with compatibility between versions that will cause problems e.g. during an upgrade. I have used three nodes running different variants of OpenSAF 5.1 and default with your patch (5.2) and have found the following: All nodes running 5.2:

Re: [devel] [PATCH 1 of 1] log: implement SaLogFilterSetCallbackT [#2146]

Hi Canh Van Truong, Sorry I was on vacation last week , will get back to soon. -AVM On 11/14/2016 4:12 PM, Canh Van Truong wrote: > osaf/libs/agents/saf/lga/lga.h|7 +- > osaf/libs/agents/saf/lga/lga_api.c|4 +- > osaf/libs/agents/saf/lga/lga_mds.c| 72

[devel] [PATCH 1 of 1] log: implement SaLogFilterSetCallbackT [#2146]

osaf/libs/agents/saf/lga/lga.h|7 +- osaf/libs/agents/saf/lga/lga_api.c|4 +- osaf/libs/agents/saf/lga/lga_mds.c| 72 +- osaf/libs/agents/saf/lga/lga_util.c | 58 - osaf/libs/common/logsv/include/lgsv_msg.h |8 +