Hi Lennart ,
I just raised Ticket to #2326 log : fix all cpp check issues, as if
#1984 pushed
I will fix #2326 as soon as possible.
-AVM
On 2/24/2017 4:53 PM, Lennart Lund wrote:
> Hi Mahesh
>
> Ack with comments
>
> Comments inline [Lennart]
>
> * Remove '#include "base/ncspatricia.h"' in
Hi Mahesh
Ack with comments
Comments inline [Lennart]
* Remove '#include "base/ncspatricia.h"' in lgs_stream.h. Not needed
* You could use C++ 11 range based for loops to simplify iterations. See
comment/example below. [Lennart]
* This patch do pass legacy tests but the following cpp check
Hi Vu,
Except replacing `const auto`, incorporated all other comments.
I will consider replacing `const auto` after 5.2 tag, to avoid last
minute change .
-AVM
On 2/24/2017 1:52 PM, Vu Minh Nguyen wrote:
> Hi Mahesh,
>
> Ack with comments, [Vu].
>
> Regards, Vu
>
>> -Original
Hi Mahesh,
Ack with comments, [Vu].
Regards, Vu
> -Original Message-
> From: mahesh.va...@oracle.com [mailto:mahesh.va...@oracle.com]
> Sent: Friday, February 24, 2017 10:34 AM
> To: canh.v.tru...@dektech.com.au; vu.m.ngu...@dektech.com.au;
> lennart.l...@ericsson.com
> Cc:
src/log/README|4 +-
src/log/README_LONGDN | 15 +---
src/log/logd/lgs_cb.h |2 -
src/log/logd/lgs_clm.cc | 25 +++-
src/log/logd/lgs_evt.cc | 123 ++---
src/log/logd/lgs_evt.h|7 ++
src/log/logd/lgs_mbcsv.cc
