[devel] [PATCH 1 of 1] osaf: Improve fault analyse by using current changeset when configuring osaf [#676]

2014-01-07 Thread Hans Nordeback
Makefile.common | 4 ++-- bootstrap.sh | 4 +++- configure.ac | 3 +++ osaf/libs/core/common/daemon.c | 4

Re: [devel] [PATCH 1 of 1] osaf: Improve fault analyse by using current changeset when configuring osaf [#676]

2014-01-07 Thread Anders Widell
Ack (not tested) regards, Anders Widell 2014-01-07 12:35, Hans Nordeback skrev: Makefile.common | 4 ++-- bootstrap.sh | 4 +++- configure.ac | 3 +++

Re: [devel] [PATCH 1 of 1] osaf: Improve fault analyse by using current changeset when configuring osaf [#676]

2014-01-07 Thread Mathivanan Naickan Palanivelu
Ack. -Mathi. -Original Message- From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com] Sent: Tuesday, January 07, 2014 5:05 PM To: anders.wid...@ericsson.com; Mathivanan Naickan Palanivelu Cc: opensaf-devel@lists.sourceforge.net Subject: [PATCH 1 of 1] osaf: Improve fault analyse

Re: [devel] [PATCH 1 of 1] osaf: Improve fault analyse by using current changeset when configuring osaf [#676]

2013-12-20 Thread Anders Widell
I think something like this could do the trick: In configure.ac: INTERNAL_VERSION_ID=0: AC_SUBST([INTERNAL_VERSION_ID]) In bootstrap.sh: autoreconf -vi sed -i s/^INTERNAL_VERSION_ID=.*\$/INTERNAL_VERSION_ID=$(hg parent --template {rev}:{node|short})/ configure regards, Anders

Re: [devel] [PATCH 1 of 1] osaf: Improve fault analyse by using current changeset when configuring osaf [#676]

2013-12-20 Thread Hans Nordebäck
great, I'll check this. Yes it is important that it works for osaf distributions. /Regards HansN Från: Anders Widell Skickat: den 20 december 2013 11:00 Till: Hans Nordebäck; mathi.naic...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Ämne: Re: [PATCH

Re: [devel] [PATCH 1 of 1] osaf: Improve fault analyse by using current changeset when configuring osaf [#676]

2013-12-19 Thread Mathivanan Naickan Palanivelu
Hi HansN, Good that you are sending this. Some additional info to think about: 1) There is already an existing configure option --with_rpm_release And a AC_SUBSTed variable OPENSAF_RPM_RELEASE. You may think of using this... 2) If the above variable does not sound interesting to you then now

Re: [devel] [PATCH 1 of 1] osaf: Improve fault analyse by using current changeset when configuring osaf [#676]

2013-12-19 Thread Mathivanan Naickan Palanivelu
But, you should also take care of the case when this value is empty(does not get set for whatever reason). - Mathi. -Original Message- From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com] Sent: Thursday, December 19, 2013 3:28 PM To: Mathivanan Naickan Palanivelu; Anders Widell

Re: [devel] [PATCH 1 of 1] osaf: Improve fault analyse by using current changeset when configuring osaf [#676]

2013-12-19 Thread Anders Widell
Hi! Some comments: It seems that if you put it as a static const char* xyz = ABC, then the string will be a read-only string that is only present in the executable and doesn't get copied into the core dump. To make sure the string ends up in the core dump, you could allocate it dynamically by