[devel] [PATCH 1 of 2] IMM: add error strings for CCB operations for ERR_NOT_EXIST error [#459]

2014-04-14 Thread Zoran Milinkovic
osaf/services/saf/immsv/immnd/ImmModel.cc | 66 +++ osaf/services/saf/immsv/immnd/ImmModel.hh | 5 ++ osaf/services/saf/immsv/immnd/immnd_evt.c | 27 +++- 3 files changed, 95 insertions(+), 3 deletions(-) IMM service should give more information in the

Re: [devel] [PATCH 1 of 2] IMM: add error strings for CCB operations for ERR_NOT_EXIST error [#459]

2014-04-07 Thread Hans Feldt
Some feedback on the strings produced: instead of: ERR_NOT_EXIST: object '%s' does not have an implementer and flag SA_IMM_CCB_REGISTERED_OI is set we could have: ERR_NOT_EXIST: object '%s' exist but no implementer (which is required) and: ERR_NOT_EXIST: object '%s' does not exist Any

Re: [devel] [PATCH 1 of 2] IMM: add error strings for CCB operations for ERR_NOT_EXIST error [#459]

2014-04-07 Thread Anders Björnerstedt
Yes its OK, the only thought I had here was that perhaps there could be an advantage if the error string returned over the API was identical to the related syslog message. /AndersBj -Original Message- From: Hans Feldt [mailto:hans.fe...@ericsson.com] Sent: den 7 april 2014 13:49 To:

Re: [devel] [PATCH 1 of 2] IMM: add error strings for CCB operations for ERR_NOT_EXIST error [#459]

2014-04-07 Thread Anders Björnerstedt
Actually, this was a trace and not a syslog message, so forget that. /AndersBj -Original Message- From: Anders Björnerstedt Sent: den 7 april 2014 15:01 To: Hans Feldt; Zoran Milinkovic; reddy.neelaka...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: RE: [devel] [PATCH 1

Re: [devel] [PATCH 1 of 2] IMM: add error strings for CCB operations for ERR_NOT_EXIST error [#459]

2014-04-07 Thread Hans Feldt
Guess the idea when we have error strings is that we should not have syslogs :-) /Hans -Original Message- From: Anders Björnerstedt Sent: den 7 april 2014 15:01 To: Hans Feldt; Zoran Milinkovic; reddy.neelaka...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: RE: [devel]

Re: [devel] [PATCH 1 of 2] IMM: add error strings for CCB operations for ERR_NOT_EXIST error [#459]

2014-04-07 Thread Zoran Milinkovic
The ticket had been written only for the first case ERR_NOT_EXIST: object '%s' exist but no implementer (which is required). I'll change the text before I push the code. Regards, Zoran -Original Message- From: Hans Feldt Sent: den 7 april 2014 13:49 To: Zoran Milinkovic;

Re: [devel] [PATCH 1 of 2] IMM: add error strings for CCB operations for ERR_NOT_EXIST error [#459]

2014-04-07 Thread Anders Björnerstedt
Yes the default assumption when receiving ERR_NOT_EXIST on an attempt to to ccb-delete or ccb-modify an object has to be that it is the object that does not exist. For ccb-create, ERR_NOT_EXIST actually has a lot of ambiguity, it means one of: - Parent does not exist. - class corresponding to

Re: [devel] [PATCH 1 of 2] IMM: add error strings for CCB operations for ERR_NOT_EXIST error [#459]

2014-04-03 Thread Hans Feldt
I think this patch is a bit controversial. We need to define a protocol for the text carried in the error strings to allow for future changes. For example we should consider source identification, maybe we should have key/value pairs in the string? Remember that the string might end up in

Re: [devel] [PATCH 1 of 2] IMM: add error strings for CCB operations for ERR_NOT_EXIST error [#459]

2014-04-03 Thread Anders Bjornerstedt
Anders Björnerstedt wrote: This patch only affects the ccb-operation callbacks for ccb- create/delete/modify. It does not append anything to a user error string since the callback never reached the user. It adds an error string in the imm server where there previously could be no string,

[devel] [PATCH 1 of 2] IMM: add error strings for CCB operations for ERR_NOT_EXIST error [#459]

2014-04-02 Thread Zoran Milinkovic
osaf/services/saf/immsv/immnd/ImmModel.cc | 60 +++ osaf/services/saf/immsv/immnd/ImmModel.hh | 5 ++ osaf/services/saf/immsv/immnd/immnd_evt.c | 27 - 3 files changed, 89 insertions(+), 3 deletions(-) When an implementer is detached from an