Hi Nagu
Sorry, I forgot to change the 3 instances of '%d' below, to '%u'.
Can you please change before pushing, or should I send another patch?
Thanks
Gary
On Mon, 2014-06-02 at 13:08 +1000, Gary Lee wrote:
+
+void su_increment_su_restart_count(AVND_SU su)
+{
+ su.su_restart_cnt++;
+
Subject: Re: [devel] [PATCH 1 of 2] amfnd: Improve logging for error
escalation
decisions [#870]
Hi Nagu
Sorry, I forgot to change the 3 instances of '%d' below, to '%u'.
Can you please change before pushing, or should I send another patch?
Thanks
Gary
On Mon, 2014-06-02 at 13
Ack,
Minor comments inline.
Additionally, should we log when a probation timer is started and its duration?
I think it would be good, then we can see how a user has configured and we can
correlate with the timeout log entry. We can add this in a subsequent patch.
Thanks,
Hans
-Original
Ack.
Can you please update the ticket with the below remarks:
* log when SU restart/failover limits have been reached
* log each time a SU restart/failover occurs
* add a log entry when error escalation is changed
* log each time a component is restarted, or when restart limits have been
osaf/services/saf/amf/amfnd/err.cc| 48 +++---
osaf/services/saf/amf/amfnd/include/avnd_cb.h | 2 +
osaf/services/saf/amf/amfnd/include/avnd_su.h | 3 +
osaf/services/saf/amf/amfnd/su.cc | 23
4 files changed, 69 insertions(+), 7
: [devel] [PATCH 1 of 2] amfnd: Improve logging for error
escalation
decisions [#870]
Hi again :)
On 30/05/14 11:05, Gary Lee wrote:
2. too many times doesn't look good.
LOG_NO(components of '%s' restarted too many times (comp restart count:
%d) should be changed to
LOG_NO
Hi Gary,
We have agreement on #1 and #2(in another email).
For #3,
It seems to me it would be less 'noisy' if we didn't include the
configured / escalated recovery methods every time. Can we keep the
proposed change?
Fine with little two modifications.
1. Recovery is always on components,
Few comments:
1. All %d should be converted to %u.
2. too many times doesn't look good.
LOG_NO(components of '%s' restarted too many times (comp restart count: %d)
should be changed to
LOG_NO(components of '%s' restarted exceeds configured '%u' (comp restart
count: %u),
Hi again :)
On 30/05/14 11:05, Gary Lee wrote:
2. too many times doesn't look good.
LOG_NO(components of '%s' restarted too many times (comp restart count: %d)
should be changed to
LOG_NO(components of '%s' restarted exceeds configured '%u' (comp
restart count: %u),
osaf/services/saf/amf/amfnd/err.cc| 77 --
osaf/services/saf/amf/amfnd/include/avnd_cb.h | 2 +
osaf/services/saf/amf/amfnd/include/avnd_su.h | 3 +
osaf/services/saf/amf/amfnd/su.cc | 23
4 files changed, 98 insertions(+), 7
osaf/services/saf/amf/amfnd/err.cc| 61 +++---
osaf/services/saf/amf/amfnd/include/avnd_cb.h | 2 +
osaf/services/saf/amf/amfnd/include/avnd_su.h | 3 +
osaf/services/saf/amf/amfnd/su.cc | 23 ++
4 files changed, 82 insertions(+), 7
On 26/05/14 13:46, Gary Lee wrote:
diff --git a/osaf/services/saf/amf/amfnd/su.cc
b/osaf/services/saf/amf/amfnd/su.cc
--- a/osaf/services/saf/amf/amfnd/su.cc
+++ b/osaf/services/saf/amf/amfnd/su.cc
@@ -462,6 +462,8 @@ uint32_t avnd_evt_tmr_su_err_esc_evh(AVN
}
TRACE('%s',
12 matches
Mail list logo
