Re: [devel] [PATCH 2/3] base: add config file reader [#2923]

2018-09-24 Thread Hans Nordeback
ack, code review only. /Thanks HansN On 09/21/2018 08:55 AM, Gary Lee wrote: Some configuration attribute are read by OpenSAF daemons as environment variables. eg. export FMS_PROMOTE_ACTIVE_TIMER=0 There is no easy way to reload these values without a restart. ConfigFileReader will parse

Re: [devel] [PATCH 2/3] base: add config file reader [#2923]

2018-09-20 Thread Gary Lee
Thanks Hans, I'll rewrite that part. -Original Message- From: Hans Nordeback Date: Thursday, 20 September 2018 at 10:18 pm To: gary Cc: Subject: Re: [PATCH 2/3] base: add config file reader [#2923] Hi Gary, I think we need to replace the use of std::regex for now.

Re: [devel] [PATCH 2/3] base: add config file reader [#2923]

2018-09-20 Thread Gary Lee
According to https://isocpp.org/blog/2014/04/gcc-4.9.0 It's been released for over 4 years. -Original Message- From: gary Date: Thursday, 20 September 2018 at 10:11 pm To: Hans Nordeback Cc: Subject: Re: [devel] [PATCH 2/3] base: add config file reader [#2923] Hi Hans

Re: [devel] [PATCH 2/3] base: add config file reader [#2923]

2018-09-20 Thread Gary Lee
Hi Hans Just tested it with 4.9.3 and it works fine. It doesn't link with 4.8.5 config_file_reader.cc:(.text+0x1c8): undefined reference to `std::regex_token_iterator<__gnu_cxx::__normal_iterator, char, std::regex_traits >::regex_token_iterator(__gnu_cxx::__normal_iterator,

Re: [devel] [PATCH 2/3] base: add config file reader [#2923]

2018-09-20 Thread Hans Nordeback
ack, review only. Some comments below. /Thanks HansN On 09/19/2018 05:42 AM, Gary Lee wrote: Some configuration attribute are read by OpenSAF daemons as environment variables. eg. export FMS_PROMOTE_ACTIVE_TIMER=0 There is no easy way to reload these values without a restart.

[devel] [PATCH 2/3] base: add config file reader [#2923]

2018-09-18 Thread Gary Lee
Some configuration attribute are read by OpenSAF daemons as environment variables. eg. export FMS_PROMOTE_ACTIVE_TIMER=0 There is no easy way to reload these values without a restart. ConfigFileReader will parse these files looking for 'export VAR=VAL' and store them into a map, so a daemon can

[devel] [PATCH 2/3] base: add config file reader [#2923]

2018-09-18 Thread Gary Lee
Some configuration attribute are read by OpenSAF daemons as environment variables. eg. export FMS_PROMOTE_ACTIVE_TIMER=0 There is no easy way to reload these values without a restart. ConfigFileReader will parse these files looking for 'export VAR=VAL' and store them into a map, so a daemon can