Hi Ramesh,
- Most of the your review comment are related to cpnd_ckpt_sec_write()
in case of cpnd_ckpt_sec_write fail nothing to be rollback of any
cktp/section recently/long back/just- created
just need to report we are not able to write user data in to SHM, so
that the user will
Hi Mahesh,
Please find my review comments inline with [Ramesh].
Thanks,
Ramesh.
On 11/29/2016 4:07 PM, mahesh.va...@oracle.com wrote:
> osaf/libs/common/cpsv/include/cpnd_cb.h | 4 +-
> osaf/libs/common/cpsv/include/cpnd_init.h | 8 +-
> osaf/libs/common/cpsv/include/cpnd_sec.h | 2
Hi Hoang,
On 12/1/2016 9:15 AM, Vo Minh Hoang wrote:
> Dear Mahesh,
>
> I have one small concern about:
> Please consider get CB data by ncshm_take_hdl() or pass in ensures_space as
> parameter.
> When CB is global access, adding it to parameters of many API is a little
> bit inconvenient.
The
Dear Mahesh,
I have one small concern about:
Please consider get CB data by ncshm_take_hdl() or pass in ensures_space as
parameter.
When CB is global access, adding it to parameters of many API is a little
bit inconvenient.
And passing CB for just one ensures_space param might confuse the usage
osaf/libs/common/cpsv/include/cpnd_cb.h | 4 +-
osaf/libs/common/cpsv/include/cpnd_init.h | 8 +-
osaf/libs/common/cpsv/include/cpnd_sec.h | 2 +-
osaf/libs/core/include/ncs_osprm.h| 2 +-
osaf/services/saf/cpsv/cpnd/cpnd_db.c | 12 ++--
