Re: [devel] [PATCH 2 of 3] lgs: director Cluster Membership (CLM) integration [#1638] V2

Hi Lennar, I incorporated most of your review comments except creating a LgsClm class in V3 patch please review. -AVM On 8/2/2016 6:30 PM, Lennart Lund wrote: > Hi > > My comments for patch 2 > > I have found some things that should be considered in order to get as clean > code as possible: >

Re: [devel] [PATCH 2 of 3] lgs: director Cluster Membership (CLM) integration [#1638] V2

Hi Mahesh See my new comments inline [Lennart] Thanks Lennart > -Original Message- > From: A V Mahesh [mailto:mahesh.va...@oracle.com] > Sent: den 3 augusti 2016 08:21 > To: Lennart Lund ; Vu Minh Nguyen > ; Anders Widell >

Re: [devel] [PATCH 2 of 3] lgs: director Cluster Membership (CLM) integration [#1638] V2

Hi Lennar, I just incorporated possible comments based on the current code base, This My fist patch for LOG :) , so I just followed how existing functions/variables organized like. I will considered all other inputs while doing complete refracting code to C++ in a separate ticket soon.

Re: [devel] [PATCH 2 of 3] lgs: director Cluster Membership (CLM) integration [#1638] V2

Hi My comments for patch 2 I have found some things that should be considered in order to get as clean code as possible: 1. Functions for handling CLM can be found in several files. It is better to collect all CLM handling in the lgs_clm file and just include function calls in the rest of the