Re: [devel] [PATCH 3 of 3] amfd: convert remaining macros in si.cc to functions [#713]

2014-06-16 Thread Nagendra Kumar
Ack Thanks -Nagu -Original Message- From: Gary Lee [mailto:gary@dektech.com.au] Sent: 13 June 2014 11:19 To: hans.fe...@ericsson.com; hans.nordeb...@ericsson.com; Nagendra Kumar; Praveen Malviya Cc: opensaf-devel@lists.sourceforge.net Subject: [PATCH 3 of 3] amfd: convert

Re: [devel] [PATCH 3 of 3] amfd: convert remaining macros in si.cc to functions [#713]

2014-06-16 Thread Hans Nordebäck
ack/Regards HansN On 06/13/14 07:48, Gary Lee wrote: osaf/services/saf/amf/amfd/include/si.h | 10 +- osaf/services/saf/amf/amfd/sg_nway_fsm.cc| 10 +- osaf/services/saf/amf/amfd/sg_nwayact_fsm.cc | 10 +- osaf/services/saf/amf/amfd/si.cc |

Re: [devel] [PATCH 3 of 3] amfd: convert remaining macros in si.cc to functions [#713]

2014-06-15 Thread Gary Lee
Hi Hans On 13/06/14 20:49, Hans Feldt wrote: diff --git a/osaf/services/saf/amf/amfd/include/si.h b/osaf/services/saf/amf/amfd/include/si.h --- a/osaf/services/saf/amf/amfd/include/si.h +++ b/osaf/services/saf/amf/amfd/include/si.h @@ -122,6 +122,11 @@ public: void

Re: [devel] [PATCH 3 of 3] amfd: convert remaining macros in si.cc to functions [#713]

2014-06-13 Thread Hans Feldt
First great work with this series I will try find some time to review and test. One comment inline Thanks, Hans -Original Message- From: Gary Lee [mailto:gary@dektech.com.au] Sent: den 13 juni 2014 07:49 To: Hans Feldt; Hans Nordebäck; nagendr...@oracle.com;

[devel] [PATCH 3 of 3] amfd: convert remaining macros in si.cc to functions [#713]

2014-06-12 Thread Gary Lee
osaf/services/saf/amf/amfd/include/si.h | 10 +- osaf/services/saf/amf/amfd/sg_nway_fsm.cc| 10 +- osaf/services/saf/amf/amfd/sg_nwayact_fsm.cc | 10 +- osaf/services/saf/amf/amfd/si.cc | 20 4 files changed, 35 insertions(+),