Re: [devel] [PATCH 4/4] amfd: add support for delaying node failover [#2918]

2018-10-29 Thread Gary Lee
Hi Nagu Thanks for the quick review. 1. Good point; I will set defaults at startup, in case the attributes are blank or the attribute definitions not present. 2. Yes. We need details about the node, in case it does come back. 3. They are called at these places: node_state.cc:

Re: [devel] [PATCH 4/4] amfd: add support for delaying node failover [#2918]

2018-10-29 Thread Nagendra Kumar
Hi Gary, Again, great patch! Ack with the following: 1. I hope you might have tested upgrade and downgrade test cases, where Act will not have these configuration params in xml, but Standby will try to read as it has the latest code. 2. When f/o timer expires and Amf does failover and mark

[devel] [PATCH 4/4] amfd: add support for delaying node failover [#2918]

2018-10-24 Thread Gary Lee
OpenSAF has relied on reliable, redundant links between nodes in a cluster. This can no longer be assumed in virtualised environments. In order to avoid duplicate assignments, we need to delay node failover in environments where temporary network partitioning is expected. When delayed node