Hi Thuan,
Ack, code review only. Few comments below:
- Agree, but shouldn't the description in the ticket be something like
"mds: At MDS broadcast use TIPC multicast for fragmented messages instead of
unicasting to only one destination' ?
- And adding the test cases would be good.
/BR HansN
Hi Hans,
static uint32_t mdtm_sendto(uint8_t *buffer, uint16_t buff_len,
struct tipc_portid tipc_id);
static uint32_t mdtm_mcast_sendto(void *buffer, size_t size,
const
Hi Thuan,
a question, the old code uses unicast for the fragments, now multicast is used.
But from the 'sendto' TIPC documentation:
"If the destination is a service range, the message is a multicast to all
matching sockets."
so before when unicast was used for the fragments, TIPC multicast
Hi Thuan,
that sounds good, is this how you test now? When looking at the MDS code
before this change it looks that
large multicast messages are fragmented and only sent to one receiver
using unicast, but with this change the fragments
are multicasted to all receivers, which seems more
Hi Hans,
Yes, we try that kind of basic test, IMMD can deliver big message via multicast.
Best Regards,
ThuanTr
-Original Message-
From: Hans Nordebäck
Sent: Friday, May 3, 2019 3:11 PM
To: Thuan Tran ; Minh Hon Chau
; Vu Minh Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject:
Hi Thuan,
I'm reviewing the patch now. I haven't checked yet but do you know if the mds
apitests cover this case sending large multicast messages? /Thanks HansN
-Original Message-
From: Tran Thuan
Sent: den 2 maj 2019 05:56
To: Minh Hon Chau ; Vu Minh Nguyen
; Hans Nordebäck
Cc:
Hi Hans,
Current MDS apitest only binary execution on one node.
It is easier if create IMM test case to make IMMD send broadcast big message.
I think we can create new ticket for this additional test.
Best Regards,
ThuanTr
-Original Message-
From: Hans Nordebäck
Sent: Friday, May 3,
Hi Thuan,
ok, if we can add additional tests to the mds api test suite would be
good/Thanks HansN
-Original Message-
From: Tran Thuan
Sent: den 3 maj 2019 09:41
To: Hans Nordebäck ; Minh Hon Chau
; Vu Minh Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 0/1] Review
Hi Hans,
I don't see this kind of test in mds apitests.
Best Regards,
ThuanTr
-Original Message-
From: Hans Nordebäck
Sent: Friday, May 3, 2019 2:31 PM
To: Thuan Tran ; Minh Hon Chau
; Vu Minh Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 0/1] Review Request for
Hi Hans,
Do you have any further comment?
Can we push the patch?
Best Regards,
ThuanTr
-Original Message-
From: Minh Hon Chau
Sent: Friday, April 26, 2019 4:11 PM
To: Vu Minh Nguyen ; 'Hans Nordebäck'
; 'Thuan Tran'
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 0/1]
Hi,
ack from me (code review)
Thanks
Minh
On 25/4/19 9:33 pm, Vu Minh Nguyen wrote:
Hi Hans,
Probably you were looking at code that included this Thuan's patch.
In legacy code, only mdtm_sendto() is called inside the function
mdtm_frag_and_send().
Regards, Vu
-Original Message-
Hi Vu and Thuan,
a few question, is the text in the ticket description correct? E.g it
says unicast is used if a multicast message is fragmented, (I think
multicast still is used
to send the fragments), this is what you mean with 2 different channels?
(only one socket is used, BSRsock),
The
Hi Vu, you are right, my concern was the description of the problem, and
it looks ok with your explanation. /Thanks Hans
On 2019-04-25 13:33, Vu Minh Nguyen wrote:
> Hi Hans,
>
> Probably you were looking at code that included this Thuan's patch.
>
> In legacy code, only mdtm_sendto() is called
Hi Hans,
Probably you were looking at code that included this Thuan's patch.
In legacy code, only mdtm_sendto() is called inside the function
mdtm_frag_and_send().
Regards, Vu
> -Original Message-
> From: Hans Nordebäck
> Sent: Thursday, April 25, 2019 6:10 PM
> To: Vu Minh Nguyen ;
Hi Vu,
It seems mdtm_mcast_sendto is used in mdtm_frag_and_send, at
MDS_SENDTYPE_BCAST/BR Hans
-Original Message-
From: Vu Minh Nguyen
Sent: den 25 april 2019 12:20
To: Hans Nordebäck ; Thuan Tran
; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 0/1]
Hi Hans,
See my responses inline.
Regards, Vu
> -Original Message-
> From: Hans Nordebäck
> Sent: Thursday, April 25, 2019 4:28 PM
> To: Thuan Tran ; Vu Minh Nguyen
> ; Minh Hon Chau
>
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: Re: [PATCH 0/1] Review Request for mds: support
16 matches
Mail list logo
