Re: [devel] [PATCH 1/1] smfd: Fix incorrect handling of SMFND NCSMDS_UP/DOWN events [#2821]

@dektech.com.au>; Lennart Lund > <lennart.l...@ericsson.com>; Vijay Roy <vijay@oracle.com> > Cc: opensaf-devel@lists.sourceforge.net > Subject: RE: [devel] [PATCH 1/1] smfd: Fix incorrect handling of SMFND > NCSMDS_UP/DOWN events [#2821] > > Hi Nguyen, > > Rev

Re: [devel] [PATCH 1/1] smfd: Fix incorrect handling of SMFND NCSMDS_UP/DOWN events [#2821]

pensaf-devel@lists.sourceforge.net Subject: Re: [devel] [PATCH 1/1] smfd: Fix incorrect handling of SMFND NCSMDS_UP/DOWN events [#2821] Hi, I intend to push this patch by the end of today if there are no more comments. Thanks, Nguyen On 4/6/2018 10:54 AM, Nguyen Luu wrote: > Hi Lennart, > > Thank

Re: [devel] [PATCH 1/1] smfd: Fix incorrect handling of SMFND NCSMDS_UP/DOWN events [#2821]

Hi, I intend to push this patch by the end of today if there are no more comments. Thanks, Nguyen On 4/6/2018 10:54 AM, Nguyen Luu wrote: Hi Lennart, Thank you for your comment. You suggested that the changed files be reformatted following Google Coding Style (i.e space-indented); but

Re: [devel] [PATCH 1/1] smfd: Fix incorrect handling of SMFND NCSMDS_UP/DOWN events [#2821]

Hi Lennart, Thank you for your comment. You suggested that the changed files be reformatted following Google Coding Style (i.e space-indented); but according to OpenSAF Coding Rules , C code shall follow Linux kernel Coding Style (i.e

Re: [devel] [PATCH 1/1] smfd: Fix incorrect handling of SMFND NCSMDS_UP/DOWN events [#2821]

Hi Nguyen, Ack with comments. See below [Lennart] Thanks Lennart > -Original Message- > From: Nguyen Luu [mailto:nguyen.tk@dektech.com.au] > Sent: den 28 mars 2018 10:08 > To: Lennart Lund ; vijay@oracle.com > Cc: opensaf-devel@lists.sourceforge.net;

Re: [devel] [PATCH 1/1] smfd: Fix incorrect handling of SMFND NCSMDS_UP/DOWN events [#2821]

Hi Lennart, Vijay, Please help me review this patch whenever possible for you. Thanks, Nguyen On 3/28/2018 3:07 PM, Nguyen Luu wrote: Current handling of SMFND DOWN event does not take into account failed SMFND UP event, which could eventually result in an inexact view of the actual number of