Hi Hans, thanks, see comments below/BR HansN
-Original Message-
From: Hans Feldt [mailto:osafde...@gmail.com]
Sent: den 23 oktober 2013 08:46
To: Hans Nordebäck
Cc: Hans Feldt; praveen malviya; nagendr...@oracle.com;
opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 0 of 1]
Hi Neel,
First, obviously we did not review your fix for #560 properly.
I also now see that the changesets for the fix for #560 are actually tagged
with #563.
Ticket #560 says that the problem is related to #563, but I dont see how.
Or perhaps you just mean that you discovered problem #560 while
Hi AndersBj,
Comments Below.
/Neel
On Wednesday 23 October 2013 01:30 PM, Anders Björnerstedt wrote:
> Hi Neel,
>
> First, obviously we did not review your fix for #560 properly.
> I also now see that the changesets for the fix for #560 are actually tagged
> with #563.
> Ticket #560 says that th
Hi,
Some more comments from looking at libs/common
- I guess the tmp_common files should be removed?
- d2nedu.c, memory is allocated with malloc in a couple of places. It
is later freed from many locations by calling avsv_dnd_msg_free_TMP
which then uses delete in a couple of places. There needs
Summary: amfd: Stop cluster startup timer, if all configured nodes have joined
[#76]
Review request for Trac Ticket(s): #76
Peer Reviewer(s): Hans F, Hans N, Praveen, Mathi
Pull request to:
Affected branch(es): Default
Development branch: Default
Impacted are
osaf/services/saf/amf/amfd/include/proc.h |1 +
osaf/services/saf/amf/amfd/ndfsm.cc |4 +
osaf/services/saf/amf/amfd/ndproc.cc | 102 ++
3 files changed, 107 insertions(+), 0 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/include/proc.h
b/os
Hi, I guess libs/common are used from the agents as well and cannot be
changed to new/delete, thats why I created a tmp common to be used from c++.
If some c++ parts (not all) allocates memory via d2nedu.c they have to
use the related free method. I must have missed those calls, I'll check
this.
> -Original Message-
> From: Hans Nordebäck
> Sent: den 23 oktober 2013 12:50
> To: Hans Feldt
> Cc: Hans Feldt; praveen malviya; nagendr...@oracle.com;
> opensaf-devel@lists.sourceforge.net; Hans Nordebäck
> Subject: Re: [devel] [PATCH 0 of 1] Review Request for amf #94
>
> Hi, I guess
On 23-Oct-13 12:24 PM, Hans Feldt wrote:
> Hi,
>
> The problem is the race mentioned in the ticket. By design we want to be sure
> such race does not exist. My proposed change guarantees that we can _always_
> trust "ava down" as being a fault in the component.
In race condition there can be two
> -Original Message-
> From: praveen malviya [mailto:praveen.malv...@oracle.com]
> Sent: den 23 oktober 2013 13:39
> To: Hans Feldt
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: Re: [devel] [PATCH 1 of 1] amf: change saAmfResponse to be
> synchronous in TerminateCallback context [#5
Summary:CLM: corrected memory leaks in clma (#604)
Review request for Trac Ticket(s): 604
Peer Reviewer(s): Mathi, Ramesh
Pull request to:
Affected branch(es):4.2.x,4.3.x,default
Development branch:
Impacted area Impact y/n
---
osaf/libs/agents/saf/clma/clma_util.c | 4
1 files changed, 4 insertions(+), 0 deletions(-)
freed the memory when the clma callback is called with older version.
diff --git a/osaf/libs/agents/saf/clma/clma_util.c
b/osaf/libs/agents/saf/clma/clma_util.c
--- a/osaf/libs/agents/saf/clma/clm
On 23-Oct-13 5:16 PM, Hans Feldt wrote:
>> -Original Message-
>> From: praveen malviya [mailto:praveen.malv...@oracle.com]
>> Sent: den 23 oktober 2013 13:39
>> To: Hans Feldt
>> Cc: opensaf-devel@lists.sourceforge.net
>> Subject: Re: [devel] [PATCH 1 of 1] amf: change saAmfResponse to be
> -Original Message-
> From: praveen malviya [mailto:praveen.malv...@oracle.com]
> Sent: den 23 oktober 2013 14:05
> To: Hans Feldt
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: Re: [devel] [PATCH 1 of 1] amf: change saAmfResponse to be
> synchronous in TerminateCallback context [
But if memory is malloc'ed by the EDU's in libs/common, the same
libs/common free utils should be called and there will be no need for
tmp_common.cc ?
Now it just creates an imbalance between malloc and delete
Ideally I would like to get rid of the EDU use and do it like for
example IMM with plai
Yes, but some memory are allocated using new (before with malloc) and
not via libs/common, and free'd via e.g. avsv_dnd_msg_free. So
the short term solution is to use tmp common for these constructs and
should be reworked and removed in later patches.
/BR HansN
On 10/23/13 14:21, Hans Feldt wro
Summary: base: change ncs_os_lock to use osaf_mutex_ utils
Review request for Trac Ticket(s): 605
Peer Reviewer(s): Ramesh
Pull request to: <>
Affected branch(es): all
Development branch: 4.3
Impacted area Impact y/n
Docs
osaf/libs/core/leap/os_defs.c | 19 ++-
1 files changed, 6 insertions(+), 13 deletions(-)
Now and then a test program fails with:
os_defs.c:447: ncs_os_lock: Assertion `0' failed.
Without core dumps enabled and a console printout this error will be invisible
and undetected with
Hi Neel,
What I dont like is a having a goto tag labeled "lock_failed" that is located
before code that releases the lock. This means that the meaning of the tag has
Clearly changed and you should wither rename the tag to something else not
Just signifying that squiring the lock has failed, or mo
NACK from me.
cl_node and NCS_UNLOCK are not related at all, and freeing cl_node before
NCS_UNLOCK does not have any effect on NCS_UNLOCK.
There is a bug in locking/unlocking of the control block lock in #560 that I
missed in the review, and which may cause this assert if a client uses multiple
Hi AndersBj,
I re-checked the #560 patch and will change the goto tag of lock_fail to
a meaningful tags for the following part of the patch:
1. saImmOiRtObjectUpdate_2
2. initialize_common
and for the rest of changes, have meaningful tags.
will send the new patch for review for #602.
Thanks
Hi zoran,
I also just noticed these mis match. will resend the new patch for review.
/Neel.
On Wednesday 23 October 2013 07:33 PM, Zoran Milinkovic wrote:
> NACK from me.
>
> cl_node and NCS_UNLOCK are not related at all, and freeing cl_node before
> NCS_UNLOCK does not have any effect on NCS_UN
Moving the deadline for this forward one week from Oct 28 to Nov 4, since we
have been full up with other tickets.
At this point in time I think the most important tests/checks/analysis is to
ensure that
The 2PBE patches do not interfere with regular 1PBE/0PBE.
2PBE will only be activated if
Summary: mds: change Unix sock file osaf_dtm_intra_server path [#606]
Review request for Trac Ticket(s): #606
Peer Reviewer(s): Ramesh
Pull request to: <>
Affected branch(es): default
Development branch: default
Impacted area Impact y/n
-
osaf/services/infrastructure/nid/scripts/opensafd.in | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/osaf/services/infrastructure/nid/scripts/opensafd.in
b/osaf/services/infrastructure/nid/scripts/opensafd.in
--- a/osaf/services/infrastructure/nid/scripts/opensafd.in
++
25 matches
Mail list logo
