Re: [devel] [PATCH 1 of 1] clm: fill saClmNodeAddress and saClmNodeAddressFamily with ip info [#228]

ACK with following comments, fix them before pushing : 1) nodeAddress family is not matching with Saf values (SA_CLM_AF_INET / SA_CLM_AF_INET6, CLM nodeAddress family is getting papulated with AF_INET/AF_INET6 , please correct it .

[devel] [PATCH 0 of 1] Review Request for IMMTOOLS: fix RDN value with a DN of an associated object in immcfg [#702]

Summary: IMMTOOLS: fix RDN value with a DN of an associated object in immcfg [#702] Review request for Trac Ticket(s): 702 Peer Reviewer(s): Neelakanta Pull request to: Zoran Affected branch(es): opensaf-4.2.x, opensaf-4.3.x, default(4.4) Development branch: default(4.4)

[devel] [PATCH 1 of 1] IMMTOOLS: fix RDN value with a DN of an associated object in immcfg [#702]

osaf/tools/safimm/immcfg/imm_cfg.c | 36 +++- 1 files changed, 19 insertions(+), 17 deletions(-) Fix RDN value with a DN of an associated object when a new object is created by immcfg. diff --git a/osaf/tools/safimm/immcfg/imm_cfg.c

[devel] [PATCH 04 of 15] amfd: Correct a number of issues identified by Coverity [#680]

osaf/services/saf/amf/amfd/ndfsm.cc| 4 +++- osaf/services/saf/amf/amfd/ndproc.cc | 5 - osaf/services/saf/amf/amfd/node.cc | 12 osaf/services/saf/amf/amfd/nodegroup.cc| 18 +++--- osaf/services/saf/amf/amfd/nodeswbundle.cc | 2 +-

[devel] [PATCH 06 of 15] amfd: Correct a number of issues identified by Coverity [#680]

osaf/services/saf/amf/amfd/si.cc | 24 osaf/services/saf/amf/amfd/si_dep.cc | 11 --- osaf/services/saf/amf/amfd/siass.cc | 4 ++-- osaf/services/saf/amf/amfd/sirankedsu.cc | 15 --- 4 files changed, 30 insertions(+), 24

[devel] [PATCH 02 of 15] amfd: Correct a number of issues identified by Coverity [#680]

osaf/services/saf/amf/amfd/cluster.cc| 3 +-- osaf/services/saf/amf/amfd/comp.cc | 17 ++--- osaf/services/saf/amf/amfd/compcstype.cc | 5 + osaf/services/saf/amf/amfd/comptype.cc | 7 +-- osaf/services/saf/amf/amfd/csi.cc| 20 ++--

[devel] [PATCH 03 of 15] amfd: Correct a number of issues identified by Coverity [#680]

osaf/services/saf/amf/amfd/hlt.cc | 1 + osaf/services/saf/amf/amfd/imm.cc | 1 + osaf/services/saf/amf/amfd/include/ntf.h | 4 ++-- osaf/services/saf/amf/amfd/include/sg.h | 1 - osaf/services/saf/amf/amfd/include/susi.h | 4 ++-- 5 files changed, 6 insertions(+), 5

[devel] [PATCH 07 of 15] amfd: Correct a number of issues identified by Coverity [#680]

osaf/services/saf/amf/amfd/su.cc | 14 -- osaf/services/saf/amf/amfd/sutcomptype.cc| 4 +++- osaf/services/saf/amf/amfd/sutype.cc | 12 +--- osaf/services/saf/amf/amfd/svctype.cc| 6 +++--- osaf/services/saf/amf/amfd/svctypecstypes.cc |

[devel] [PATCH 00 of 15] Review Request for AMF: Coverity issues in amfd/amfnd [#680]

Summary: AMF: Coverity issues in amfd/amfnd [#680] Review request for Trac Ticket(s): 680 Peer Reviewer(s): Hans N, Hans F, Praveen, Nagendra Pull request to: Affected branch(es): default Development branch: default Impacted area Impact y/n

[devel] [PATCH 12 of 15] amfnd: Correct a number of issues identified by Coverity [#680]

osaf/services/saf/amf/amfnd/comp.cc | 16 ++-- osaf/services/saf/amf/amfnd/compdb.cc | 20 +--- 2 files changed, 15 insertions(+), 21 deletions(-) * Dereference after null check (FORWARD_NULL) * Logically dead code (DEADCODE) * Uninitialized scalar variable

[devel] [PATCH 09 of 15] amfd: Correct a number of issues identified by Coverity [#680]

osaf/services/saf/amf/amfd/util.cc | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) * use delete[] for variables allocated with new[] diff --git a/osaf/services/saf/amf/amfd/util.cc b/osaf/services/saf/amf/amfd/util.cc --- a/osaf/services/saf/amf/amfd/util.cc +++

[devel] [PATCH 08 of 15] amfd: Correct a number of issues identified by Coverity [#680]

osaf/services/saf/amf/amfd/compcstype.cc | 5 +++-- osaf/services/saf/amf/amfd/hlt.cc| 2 +- osaf/services/saf/amf/amfd/imm.cc| 9 ++--- 3 files changed, 10 insertions(+), 6 deletions(-) * Calling risky function (SECURE_CODING) replace calls to sprintf with snprintf

[devel] [PATCH 13 of 15] amfnd: Correct a number of issues identified by Coverity [#680]

osaf/services/saf/amf/amfnd/di.cc | 5 - osaf/services/saf/amf/amfnd/hcdb.cc | 3 +-- osaf/services/saf/amf/amfnd/main.cc | 2 +- osaf/services/saf/amf/amfnd/pg.cc | 5 ++--- osaf/services/saf/amf/amfnd/sidb.cc | 12 +++- osaf/services/saf/amf/amfnd/sudb.cc | 4 ++--

[devel] [PATCH 14 of 15] amfnd: Correct a number of issues identified by Coverity [#680]

osaf/services/saf/amf/amfnd/main.cc | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) * Calling risky function (SECURE_CODING) fix buffer overflow if a string longer than 31 chars is specified for node_type diff --git a/osaf/services/saf/amf/amfnd/main.cc

[devel] [PATCH 01 of 15] amfd: Correct a number of issues identified by Coverity [#680]

osaf/services/saf/amf/amfd/app.cc | 27 --- osaf/services/saf/amf/amfd/apptype.cc | 13 - 2 files changed, 16 insertions(+), 24 deletions(-) * Unnecessary header file (HFA) * Logically dead code (DEADCODE) * Dereference null return value (NULL_RETURNS)

[devel] [PATCH 15 of 15] amfnd: Correct a number of issues identified by Coverity [#680]

osaf/services/saf/amf/amfnd/ckpt_updt.cc | 4 ++-- osaf/services/saf/amf/amfnd/compdb.cc| 6 +++--- osaf/services/saf/amf/amfnd/sidb.cc | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) * use delete[] for variables allocated with new[] diff --git

[devel] [PATCH 11 of 15] amfnd: Correct a number of issues identified by Coverity [#680]

osaf/services/saf/amf/amfnd/clc.cc | 11 --- osaf/services/saf/amf/amfnd/clm.cc | 11 ++- 2 files changed, 10 insertions(+), 12 deletions(-) * Unnecessary header file (HFA) * Unchecked return value (CHECKED_RETURN) * Uninitialized scalar variable (UNINIT) * Out-of-bounds read