OK I got it, the for loop is needed. I have tested it and can
reproduce and see that the patch fix the problem.
Minor comments:
* the commit message is too long, you could shrink it to: "fix cleanup
of assigned comp in shutdown"
* see inline
Ack
Thanks,
Hans
On 4 February 2014 10:44, wrote:
Hi Praveen, "Review Request for amf refactoring v7 [#713]" from 2014-01-17
should be reviewed and is about replacing the patricia tree with an stl map.
Three patches follows (to start with)
where app, comp and the csi db are changed to use the stl map instead. There
are also a patch called " am
This change seems to be the same one that you just pushed as part of 767?
If so what should we do with this defect?
Thanks,
Hans
On 4 February 2014 11:36, wrote:
> osaf/services/saf/amf/amfnd/comp.cc | 7 +++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
>
> When AMFND responds to A
On 11-Feb-14 3:40 PM, Hans Feldt wrote:
> This change seems to be the same one that you just pushed as part of 767?
> If so what should we do with this defect?
This change is still valid. This is not in shutdown flow.
Removal callback will also be given in lock/shutdown operations.
Thanks,
Prave
osaf/services/saf/smfsv/smfd/SmfCampaign.cc | 16 +---
1 files changed, 9 insertions(+), 7 deletions(-)
If the the campaign return parsing error shortly after the campaign thread is
started. The campaign thread writing to error string can interfere with smfd
thread clearing the sa
Summary: No interference when error string is set after parsing error
Review request for Trac Ticket(s): 763
Peer Reviewer(s): bertil
Pull request to:
Affected branch(es): 4.3, 4.4, default
Development branch: default
Impacted area Impact y/n
---
osaf/services/saf/smfsv/smfd/SmfCampaign.cc | 21 +
1 files changed, 13 insertions(+), 8 deletions(-)
If the the campaign thread start fail shortly after it has been ordered. The
campaign thread writing to error string can interfere with smfd thread clearing
the same error
Summary: No interference when error string is set after campaign parsing error
Review request for Trac Ticket(s): 763
Peer Reviewer(s): bertil
Pull request to:
Affected branch(es): 4.3, 4.4, default
Development branch: default
Impacted area Impact y/n
--
Looks OK.
/Bertil
-Original Message-
From: Ingvar Bergström
Sent: den 11 februari 2014 13:29
To: Bertil Engelholm
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] smfd: No interference when error string is set after
campaign parsing error [#763]
osaf/services/saf/smfsv/
osaf/services/saf/amf/amfnd/comp.cc | 8 +---
1 files changed, 1 insertions(+), 7 deletions(-)
If a component crash/exits during opensaf shutdown it will delay the shutdown
with the component configured callback timeout.
The reason is that the avadown event is ignored in the shutdown state
Summary: <>
Review request for Trac Ticket(s): 778
Peer Reviewer(s): Praveen
Pull request to: <>
Affected branch(es): all
Development branch: <>
Impacted area Impact y/n
Docsn
Build systemn
R
On 11-Feb-14 7:18 PM, Hans Feldt wrote:
> osaf/services/saf/amf/amfnd/comp.cc | 8 +---
> 1 files changed, 1 insertions(+), 7 deletions(-)
>
>
> If a component crash/exits during opensaf shutdown it will delay the shutdown
> with the component configured callback timeout.
>
> The reason is
> -Original Message-
> From: praveen malviya [mailto:praveen.malv...@oracle.com]
> Sent: den 12 februari 2014 08:02
> To: Hans Feldt
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: Re: [PATCH 1 of 1] amfnd: handle avadown in shutting down [#778]
>
>
> On 11-Feb-14 7:18 PM, Hans Fel
13 matches
Mail list logo
