Re: [devel] [PATCH 1 of 1] leap: enhance posix_shm() to accommodate SaOffsetT[#1271]

Please see a question inline: - ramesh.bet...@oracle.com wrote: osaf/libs/core/include/ncs_osprm.h | 4 ++-- osaf/libs/core/leap/os_defs.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) Changed shm_size from long to uint64_t so that application can pass

Re: [devel] [PATCH 1 of 1] LOG: Fix unable to rename cfg file when changing saLogStreamFileName attribute [#1346]

Ack with a comment. Please keep the local variable name short. For eg:- this one logStreamFileName_modify, is a mix of hungarian notation and linux kernel style. You could name it as 'bool modify' or 'bool sfname_modify' Thanks, Mathi. - vu.m.ngu...@dektech.com.au wrote:

Re: [devel] [PATCH 1 of 1] ntftool: ntfread and ntfsubscribe do not check invalid options [#1355]

I think one minor change is still required as: `ntfread g` gives: Invalid non-option: g Try 'ntfread -h' for more information. But `ntfread -g` prints whole usage also. Please confirm. Thanks Praveen On 05-May-15 11:38 AM, Vu Minh Nguyen wrote: osaf/tools/safntf/ntfread/ntfread.c

[devel] [PATCH 1 of 1] smfd: get nodes for activation without warning if entity was a node [#960]

osaf/services/saf/smfsv/smfd/SmfUpgradeProcedure.cc | 8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) Symptom: Notice in system log saying that no nodes found for DN. This message would show when using nodes in activation actedOn tag in a campaign. Analysis: Just a harmless

[devel] [PATCH 0 of 1] Review Request for smfd: get nodes for activation without warning if entity was a node [#960]

Summary: smfd: get nodes for activation without warning if entity was a node [#960] Review request for Trac Ticket(s): 960 Peer Reviewer(s): bertil, ingvar Pull request to: ingvar Affected branch(es): default (4.7) Development branch: IF ANY GIVE THE REPO URL

[devel] [PATCH 1 of 1] IMM: Correction to support for admin-op for aborting non critical ccbs [#1107]

osaf/services/saf/immsv/immnd/ImmModel.cc | 34 -- 1 files changed, 23 insertions(+), 11 deletions(-) The original fix only worked for aborting CCBs where there was an OI actively involved in processing a ccb callback at the time of the admin-op. It did not work

[devel] [PATCH 0 of 1] Review Request for IMM: Correction to support for admin-op for aborting non critical ccbs [#1107]

Summary: IMM: Correction to support for admin-op for aborting non critical ccbs [#1107] Review request for Trac Ticket(s): 1107 Peer Reviewer(s): Neel;Zoran Pull request to: Affected branch(es): default(4.7) Development branch: Impacted area Impact y/n

Re: [devel] [PATCH 1 of 1] ntftool: ntfread and ntfsubscribe do not check invalid options [#1355]

Hi Praveen, Thanks for your comments. But `ntfread -g` prints whole usage also. I will update the code to make it show following format for invalid options. E.g: # ntfread -g ntfread: invalid option -- 'g' Try 'ntfread -h' for more information. Please let me know your opinions. Regards, Vu