Re: [devel] [PATCH 1 of 1] osaf: configuration support for OS whic has TIPC builtin kernel module [#1951] V1

2016-09-07 Thread Anders Widell
Ack. regards, Anders Widell On 09/06/2016 12:06 PM, mahesh.va...@oracle.com wrote: > 00-README.conf | 11 ++- > osaf/services/infrastructure/nid/scripts/configure_tipc.in | 51 > - > 2 files changed, 39 insertions(+), 23 deletions(-

[devel] [PATCH 0 of 1] Review Request for lga: ignore CLM status if client Initialize with A.2.1 [#1999]

2016-09-07 Thread mahesh . valla
Summary:lga: ignore CLM status if client Initialize with A.2.1 [#1999] Review request for Trac Ticket(s): #1999 Peer Reviewer(s): Vu, Lennart,praveen Pull request to: <> Affected branch(es): 5.1 default Development branch: default Impacted area Impact y/n --

[devel] [PATCH 1 of 1] lga: ignore CLM status if client Initialize with A.2.1 [#1999]

2016-09-07 Thread mahesh . valla
osaf/libs/agents/saf/lga/lga.h | 1 + osaf/libs/agents/saf/lga/lga_api.c | 4 +++- osaf/libs/agents/saf/lga/lga_mds.c | 12 +--- tests/logsv/tet_Log_clm.c | 35 ++- 4 files changed, 47 insertions(+), 5 deletions(-) Issue : If client saLo

Re: [devel] [PATCH 1 of 1] log: assertion failed in log_stream_close [#1954]

2016-09-07 Thread A V Mahesh
HI Vu, ACK -AVM On 8/16/2016 3:39 PM, Vu Minh Nguyen wrote: > osaf/services/saf/logsv/lgs/lgs_evt.cc | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > > Assertion failed in log_stream_close() because the caller did not check NULL > before calling the function. > > This patch

[devel] [PATCH 0 of 1] Review Request for amf: update mds version in main process[#1996]

2016-09-07 Thread praveen . malviya
Summary: amf: update mds version in main process[#1996] Review request for Trac Ticket(s): #1996 Peer Reviewer(s): AMF devs Pull request to: <> Affected branch(es): default and 5.1 Development branch: <> Impacted area Impact y/n --

[devel] [PATCH 1 of 1] amf: update mds version in main process[#1996]

2016-09-07 Thread praveen . malviya
osaf/services/saf/amf/amfd/csiattr.cc | 2 + osaf/services/saf/amf/amfd/include/evt.h| 6 + osaf/services/saf/amf/amfd/include/proc.h | 1 + osaf/services/saf/amf/amfd/main.cc | 13 -- osaf/services/saf/amf/amfd/mds.cc | 30 +++

Re: [devel] [PATCH 0 of 1] Review Request for Review Request for smfd: Merge rolling to singlestep procedures for several nodes [#1685]

2016-09-07 Thread Neelakanta Reddy
Hi Rafel, When the test is ran for rolling upgrade campaign, the following segmentation fault is observed, the campaign is faulty : Sep 7 17:38:47 SLES1 osafsmfd[4537]: ER Start of procedure thread failed for safSmfProc=amfClusterProc-1,safSmfCampaign=Campaign1,safApp=safSmfService Sep 7 1

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

2016-09-07 Thread praveen malviya
Hi Minh, Please find one query below. Thanks, Praveen On 05-Sep-16 5:07 AM, minh chau wrote: > Hi Praveen, > > I think in all cases we need to restore @admin_ng, that can tell whether > an admin operation on ng was executing. Also, we need to restore > ng_using_saAmfSGAdminState in case 2N borro

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

2016-09-07 Thread minh chau
Hi Praveen, I have checked my test cases, case 2 and 3 are created with UNLOCKED state, but both case 1 and 3 still leave all states in the same shadow after headless. Thanks, Minh On 07/09/16 22:46, praveen malviya wrote: > Hi Minh, > > Please find one query below. > > Thanks, > Praveen > > O

Re: [devel] [PATCH 1 of 1] log: fix errors reported by cppcheck version 1.75 [#1985]

2016-09-07 Thread Lennart Lund
ACK Thanks Lennart > -Original Message- > From: Canh Van Truong [mailto:canh.v.tru...@dektech.com.au] > Sent: den 31 augusti 2016 08:34 > To: Vu Minh Nguyen ; Lennart Lund > ; mahesh.va...@oracle.com > Cc: opensaf-devel@lists.sourceforge.net > Subject: [PATCH 1 of 1] log: fix errors repor

Re: [devel] [PATCH 1 of 1] log: assertion failed in log_stream_close [#1954]

2016-09-07 Thread Lennart Lund
Hi Vu ACK but a question How can a client have a "cur_rec->stream_id" but no associated stream? Should not be possible? Other problem causing this? Thanks Lennart > -Original Message- > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > Sent: den 16 augusti 2016 12:09 > To: Len

[devel] Still many open tickets on the 5.1.RC1 milestone

2016-09-07 Thread Anders Widell
Hi all! Currently we have 23 open tickets on the 5.1.RC1 milestone: https://sourceforge.net/p/opensaf/tickets/milestone/5.1.RC1/?limit=100 Don't forget to check this list on a regular basis to see if any of the open defect tickets are reported on a service you are maintaining, and/or may be ca

Re: [devel] [PATCH 1 of 1] amf: update mds version in main process[#1996]

2016-09-07 Thread Hans Nordebäck
ack, code review and tests run. /Thanks HansN On 09/07/2016 02:03 PM, praveen.malv...@oracle.com wrote: > osaf/services/saf/amf/amfd/csiattr.cc | 2 + > osaf/services/saf/amf/amfd/include/evt.h| 6 + > osaf/services/saf/amf/amfd/include/proc.h | 1 + > osaf

Re: [devel] [PATCH 0 of 1] Review Request for AMF: Fix SG unstable from admin continuation of nodegroup after headless [#1987]

2016-09-07 Thread minh chau
Hi, Please help to review this ticket. Thanks, Minh On 05/09/16 11:43, Minh Hon Chau wrote: > Summary: AMF: Fix SG unstable from admin continuation of nodegroup after > headless [#1987] > Review request for Trac Ticket(s): 1987 > Peer Reviewer(s): AMF devs > Pull request to: <> > Affected branc

Re: [devel] [PATCH 0 of 1] Review Request for imm: Remove the poll timeout in IMM testcases [#1970]

2016-09-07 Thread Neelakanta Reddy
Hi Hung, Reviewed and tested the patch. Ack. /Neel. On 2016/08/26 12:02 PM, Hung Nguyen wrote: > Summary: imm: Remove the poll timeout in IMM testcases [#1970] > Review request for Trac Ticket(s): 1970 > Peer Reviewer(s): Zoran, Neel > Pull request to: > Affected branch(es): 4.7, 5.0, 5.1 > Deve

Re: [devel] [PATCH 0 of 1] Review Request for imm: Remove pthread_exit from IMM test [#1973]

2016-09-07 Thread Neelakanta Reddy
Hi Hung, Reviewed the patch. Ack. /Neel. On 2016/08/26 04:14 PM, Hung Nguyen wrote: > Summary: imm: Remove pthread_exit from IMM test [#1973] > Review request for Trac Ticket(s): 1973 > Peer Reviewer(s): Zoran, Neel > Pull request to: > Affected branch(es): 4.7, 5.0, 5.1 > Development branch: 5.