Re: [devel] [PATCH 1 of 1] smf: reading of IMM longdn attribute at the camapign admin operation [#2087]

2016-10-10 Thread Lennart Lund
Ack Thanks Lennart > -Original Message- > From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com] > Sent: den 5 oktober 2016 14:32 > To: Lennart Lund ; Rafael Odzakow > > Cc: opensaf-devel@lists.sourceforge.net > Subject: [PATCH 1 of 1] smf: reading of IMM longdn attribute

Re: [devel] [PATCH 1 of 1] log: fix failure to create directory when changing logRootDirectory [#2054]

2016-10-10 Thread Lennart Lund
Hi Vu Ack with comment. See below /*** * Support older check-point protocols prior to version 5 */ /** * Used for updating logRootDirectory on standby when check-pointed * * Set the logRootDirectory parameter in the lgs_conf struct * Used for holding data from config object * * @param roo

[devel] [PATCH 1 of 1] log: fix saLogStreamOpen_2 returns SA_AIS_ERR_BAD_OPERATION during si-swap [#2093]

2016-10-10 Thread Vu Minh Nguyen
osaf/services/saf/logsv/lgs/lgs_evt.cc | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) During si-swap, old active logd will enter QUEISED HA state, then STANDBY. In QUEISED state, IMM OI implementer will be cleared. If opening a new application stream or closing an app stre

[devel] [PATCH 0 of 1] Review Request for log: fix saLogStreamOpen_2 returns SA_AIS_ERR_BAD_OPERATION during si-swap [#2093] V2

2016-10-10 Thread Vu Minh Nguyen
Summary: log: fix saLogStreamOpen_2 returns SA_AIS_ERR_BAD_OPERATION during si-swap [#2093] V2 Review request for Trac Ticket(s): #2093 Peer Reviewer(s): Lennart, Mahesh Pull request to: <> Affected branch(es): All Development branch: Default Impacted area I

Re: [devel] [PATCH 1 of 1] smfd: handle failed si-swap of middleware [#1605]

2016-10-10 Thread Neelakanta Reddy
Hi Alex, Reviewed and tested the patch. Ack. /Neel. On 2016/10/07 11:10 PM, Alex Jones wrote: > osaf/services/saf/smfsv/smfd/SmfStepState.cc| 13 > osaf/services/saf/smfsv/smfd/SmfUpgradeProcedure.cc | 68 > +--- > osaf/services/saf/smfsv/smfd/SmfUpgradeProced

Re: [devel] [PATCH 1 of 1] ntf: fix ntfa does not remove subscriber in subscriberNoList at finalize [#1978]

2016-10-10 Thread minh chau
Hi Canh, Ack from me Thanks, Minh On 28/09/16 13:35, Canh Van Truong wrote: > osaf/libs/agents/saf/ntfa/ntfa_api.c | 2 + > osaf/libs/agents/saf/ntfa/ntfa_util.c| 68 > +++ > tests/ntfsv/tet_saNtfNotificationSubscribe.c | 32 + > 3 fi

Re: [devel] [PATCH 1 of 1] smf: Fix loop timeout in admin operation handling [#2066]

2016-10-10 Thread Neelakanta Reddy
Hi Lennart, Reviewed the patch. Following are the comments: 1. The timeout for each admin operation must be "smfd_cb->adminOpTimeout". The smfd_cb->adminOpTimeout is configurable, if the adminoperation timeout passed is less than smfd_cb->adminOpTimeout there is a chance, to get TIMEOUT. 2. Th

[devel] [PATCH 0 of 1] Review Request for base: Add classes for UNIX socket operations and log message formatting [#2064]

2016-10-10 Thread Anders Widell
Summary: base: Add classes for UNIX socket operations and log message formatting [#2064] Review request for Trac Ticket(s): 2064 Peer Reviewer(s): Ramesh Pull request to: Affected branch(es): default(5.2) Development branch: default Impacted area Impact y/n

[devel] [PATCH 1 of 1] base: Add classes for UNIX socket operations and log message formatting [#2064]

2016-10-10 Thread Anders Widell
osaf/libs/core/cplusplus/base/Makefile.am | 13 +- osaf/libs/core/cplusplus/base/buffer.h | 100 osaf/libs/core/cplusplus/base/log_message.cc| 130 +++ osaf/libs/core/cplusplus/base/log_message.h | 186 o

[devel] [PATCH 0 of 1] Review Request for plm: log entity path for failed HPI calls [#2109]

2016-10-10 Thread Alex Jones
Summary: plm: log entity paths for failed HPI calls Review request for Trac Ticket(s): 2109 Peer Reviewer(s): Mathi Pull request to: Affected branch(es): default, 5.1, 5.0 Development branch: Impacted area Impact y/n Docs

[devel] [PATCH 1 of 1] plm: log entity paths for failed HPI calls [#2109]

2016-10-10 Thread Alex Jones
osaf/libs/common/plmsv/include/plms_hsm.h | 4 +- osaf/services/saf/plmsv/plms/hpi_intf/plms_epath_util.c | 32 - osaf/services/saf/plmsv/plms/hpi_intf/plms_hrb.c| 7 +- osaf/services/saf/plmsv/plms/hpi_intf/plms_hsm.c| 54 4 files chang

[devel] [PATCH 1 of 1] immtool: Don't finalize admo if it hasn't been initialized [#2107]

2016-10-10 Thread Hung Nguyen
osaf/tools/safimm/immcfg/imm_cfg.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Don't finalize admo if it hasn't been initialized. diff --git a/osaf/tools/safimm/immcfg/imm_cfg.c b/osaf/tools/safimm/immcfg/imm_cfg.c --- a/osaf/tools/safimm/immcfg/imm_cfg.c +++ b/osaf/tools/safimm/

[devel] [PATCH 0 of 1] Review Request for immtool: Dont finalize admo if it hasnt been initialized [#2107]

2016-10-10 Thread Hung Nguyen
Summary: immtool: Don't finalize admo if it hasn't been initialized [#2107] Review request for Trac Ticket(s): 2107 Peer Reviewer(s): Zoran, Neel Pull request to: Affected branch(es): 5.1, 5.2 Development branch: 5.2 Impacted area Impact y/n -

[devel] [PATCH 0 of 1] Review Request for log: fix saLogStreamOpen_2 returns SA_AIS_ERR_BAD_OPERATION during si-swap [#2093] V3

2016-10-10 Thread Vu Minh Nguyen
Summary: log: fix saLogStreamOpen_2 returns SA_AIS_ERR_BAD_OPERATION during si-swap [#2093] Review request for Trac Ticket(s): #2093 Peer Reviewer(s): Lennart, Mahesh Pull request to: <> Affected branch(es): all Development branch: all Impacted area Impact y

[devel] [PATCH 1 of 1] log: fix saLogStreamOpen_2 returns SA_AIS_ERR_BAD_OPERATION during si-swap [#2093]

2016-10-10 Thread Vu Minh Nguyen
osaf/services/saf/logsv/lgs/lgs_evt.cc | 12 +++- tests/logsv/tet_saLogStreamOpen_2.c| 101 + 2 files changed, 111 insertions(+), 2 deletions(-) During si-swap, old active logd will enter QUEISED HA state, then STANDBY. In QUEISED state, IMM OI implementer