Re: [devel] [PATCH 1 of 1] fm: Add support for differentiating a hung node versus a stopped node V3 [#2160]

2016-12-06 Thread Mathivanan Naickan Palanivelu
Ack, Not tested (Because I don't know have the testbed :-)) Mathi. > -Original Message- > From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com] > Sent: Wednesday, November 23, 2016 7:15 PM > To: Ramesh Babu Betham; Mathivanan Naickan Palanivelu; > anders.wid...@ericsson.com > Cc: ope

Re: [devel] [PATCH 1 of 1] imm:allow augumentCcbInit with ROF as false in completed callback[#1956] V3

2016-12-06 Thread Hung Nguyen
Hi Neel, Tested the patch and had coredump from pbe and appliers. 1. In case of applier, imma_proc_ccbaug_setup() return immediately if(cl_node->isApplier) {return;} so callback->attrValsForCreateUc is not populated. 2. When creating runtime object, the callback type is IMMA_CALLBACK_PBE_PRT_O

Re: [devel] [PATCH 0 of 1] Review Request for amfd: remove redundant notifications to RDE [#2115]

2016-12-06 Thread praveen malviya
Hi Gary, The ticket number seems to be wrong. It must be #2216. Please confirm. Thanks, Praveen On 06-Dec-16 9:20 AM, Gary Lee wrote: > Summary: amfd: remove redundant notifications to RDE [#2115] > Review request for Trac Ticket(s): 2115 > Peer Reviewer(s): AndersW, AMF devs > Pull request to: <

Re: [devel] [PATCH 0 of 1] Review Request for amfd: remove redundant notifications to RDE [#2115]

2016-12-06 Thread Gary Lee
Hi Praveen Yes, it should be #2216. Thanks On 6 Dec. 2016 8:51 pm, praveen malviya wrote: > > Hi Gary, > The ticket number seems to be wrong. It must be #2216. > Please confirm. > > Thanks, > Praveen > > On 06-Dec-16 9:20 AM, Gary Lee wrote: > > Summar

Re: [devel] [PATCH 1 of 1] imm:allow augumentCcbInit with ROF as false in completed callback[#1956] V3

2016-12-06 Thread Neelakanta Reddy
Hi Hung, Thanks for your comments. will re-publish the patch, shortly. /Neel. On 2016/12/06 02:21 PM, Hung Nguyen wrote: > Hi Neel, > > Tested the patch and had coredump from pbe and appliers. > > 1. In case of applier, imma_proc_ccbaug_setup() return immediately > if(cl_node->isApplier) {return

[devel] [PATCH 0 of 1] Review Request for imm:allow augumentCcbInit with ROF as false in completed callback[#1956] V4

2016-12-06 Thread reddy . neelakanta
Summary:imm:allow augumentCcbInit with ROF as false in completed callback[#1956] V4 Review request for Trac Ticket(s): 1956 Peer Reviewer(s): Hung, Zoran Affected branch(es): 5.0.x, 5.1.x, default Development branch: default Impacted area Impact y/n ---

[devel] [PATCH 1 of 1] imm:allow augumentCcbInit with ROF as false in completed callback[#1956] V4

2016-12-06 Thread reddy . neelakanta
osaf/libs/agents/saf/imma/imma_cb.h |5 + osaf/libs/agents/saf/imma/imma_db.c | 41 + osaf/libs/agents/saf/imma/imma_oi_api.c | 102 ++- osaf/libs/agents/saf/imma/imma_om_api.c | 11 +- osaf/libs/agents/saf/imma/imma_proc.c | 134 ++--

Re: [devel] [PATCH 1 of 1] amf: Spare controller did not get rebooted when amfd is killed on spare controller with headless [#1857]

2016-12-06 Thread praveen malviya
Ack. Thanks, Praveen On 30-Nov-16 1:29 PM, Hans Nordeback wrote: > osaf/services/saf/amf/amfnd/main.cc | 51 > +--- > 1 files changed, 46 insertions(+), 5 deletions(-) > > > diff --git a/osaf/services/saf/amf/amfnd/main.cc > b/osaf/services/saf/amf/amfnd/main.

Re: [devel] [PATCH 0 of 5] Review Request for imm: Compile the IMM library using the C++ compiler [#2142]

2016-12-06 Thread Neelakanta Reddy
Hi Hung, Reviewed and tested the patch. Ack. /Neel. On 2016/11/03 04:30 PM, Hung Nguyen wrote: > Summary: imm: Compile the IMM library using the C++ compiler [#2142] > Review request for Trac Ticket(s): 2142 > Peer Reviewer(s): Zoran, Neel > Pull request to: > Affected branch(es): 5.2 > Developm

Re: [devel] [PATCH 0 of 1] Review Request for smf:Allow optimization at node level forAddRemove in mergeStepIntoSingle[#2214]

2016-12-06 Thread Rafael Odzakow
Reviewed, ACK from me. On 12/02/2016 11:52 AM, reddy.neelaka...@oracle.com wrote: > Summary: smf:Allow optimization at node level forAddRemove in > mergeStepIntoSingle[#2214] > Review request for Trac Ticket(s): 2214 > Peer Reviewer(s): Rafael, Lennart, tai > Affected branch(es): 5.0.x, 5.1.x, d

Re: [devel] [PATCH 1 of 1] smf:Allow optimization at node level forAddRemove in mergeStepIntoSingle[#2214]

2016-12-06 Thread Lennart Lund
Ack Thanks Lennart > -Original Message- > From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com] > Sent: den 2 december 2016 11:52 > To: Tai Chi Dinh ; Lennart Lund > ; Rafael Odzakow > > Cc: opensaf-devel@lists.sourceforge.net > Subject: [PATCH 1 of 1] smf:Allow optimiza

[devel] [PATCH 1 of 1] dtm: Terminate log server thread before destroying LogServer object [#2218]

2016-12-06 Thread Anders Widell
osaf/services/infrastructure/dtms/transport/main.cc | 33 +--- 1 files changed, 27 insertions(+), 6 deletions(-) There were error handling paths where the LogServer object went out of scope and was destroyed while the log server thread was still running and using the LogServer o

[devel] [PATCH 0 of 1] Review Request for dtm: Terminate log server thread before destroying LogServer object [#2218]

2016-12-06 Thread Anders Widell
Summary: dtm: Terminate log server thread before destroying LogServer object [#2218] Review request for Trac Ticket(s): 2218 Peer Reviewer(s): Mahesh Pull request to: Affected branch(es): default(5.2) Development branch: default Impacted area Impact y/n ---

Re: [devel] [tickets] [opensaf:tickets] #2118 PLM: add ability to scale out EEs dynamically

2016-12-06 Thread Alex Jones
Oops. I just updated that and the Makefile. Alex On 12/06/2016 02:06 AM, Mathivanan Naickan Palanivelu wrote: > > NOTICE: This email was received from an EXTERNAL sender >

Re: [devel] [PATCH 1 of 1] imm:allow augumentCcbInit with ROF as false in completed callback[#1956] V4

2016-12-06 Thread Zoran Milinkovic
Hi Neelakanta, saImmOmAccessorGet_o3() in immsv_om_augment_ccb_get_admo_name() will not work for IMM handles initialized with versions earlier than A.2.15. You can add SaNameT variable in the function, set object in the variable, and call saImmOmAccessorGet_2(). Or you can make it in an easy way

Re: [devel] [PATCH 1 of 1] fm: Add support for differentiating a hung node versus a stopped node V3 [#2160]

2016-12-06 Thread Anders Widell
Ack with comments, see inline marked [AndersW] regards, Anders Widell On 11/23/2016 02:45 PM, Hans Nordeback wrote: > osaf/services/infrastructure/fm/fms/fm_cb.h | 1 + > osaf/services/infrastructure/fm/fms/fm_evt.h | 1 + > osaf/services/infrastructure/fm/fms/fm_main.c | 54 >

Re: [devel] [PATCH 1 of 1] mds: Remove use of mutex at TIPC receive (part 1) V3 [#2132]

2016-12-06 Thread A V Mahesh
Hi HansN, I did some investigation my fist observation is , issues occurring because of delayed processing of Control /(FD_DSOCK/ = /POLLIN)/, Timer (/FD_TMRFD = //POLLIN ) /and Discovery Socket lost the connectivity with the topology events (/[FD_DSOCK= //POLLHUP/ ), and this is occurring be

Re: [devel] [PATCH 1 of 1] imm:allow augumentCcbInit with ROF as false in completed callback[#1956] V4

2016-12-06 Thread Neelakanta Reddy
Hi Zoran, The saImmOmAccessorGet_o3 is called by the privateOMhandle initialized by saImmOiAugmentCcbInitialize with version A.2.17. This is hard-coded in the saImmOiAugmentCcbInitialize. Thanks, Neel On 2016/12/06 08:38 PM, Zoran Milinkovic wrote: > Hi Neelakanta, > > saImmOmAccessorGet_o3() i

Re: [devel] [PATCH 0 of 1] Review Request for smf:Allow optimization at node level forAddRemove in mergeStepIntoSingle[#2214]

2016-12-06 Thread Neelakanta Reddy
Hi Rafael, Can you please comment on the below points: 1. forAddRemove Optimization of node must be present in both activation and deactivation. (The published patch does not check if the node is present in both AU & DU). 2. The published patch must also include for Su/Comp and optimize if