[devel] [PATCH 0 of 1] Review Request for log: fix logd crash on Active side [#2362] V1

Summary: log: fix logd crash on Active side [#2362] V1 Review request for Trac Ticket(s): #2362 Peer Reviewer(s): Lennart, Vu, Mahesh Pull request to: Vu Affected branch(es): default Development branch: default Impacted area Impact y/n

[devel] [PATCH 0 of 1] Review Request for base: Improve trace by using tid instead of pid [#2370]

Summary: base: Improve trace by using tid instead of pid Review request for Trac Ticket(s): #2370 Peer Reviewer(s): Ramesh, AndersW Pull request to: Affected branch(es): default Development branch: default Impacted area Impact y/n

[devel] [PATCH 1 of 1] base: Improve trace by using tid instead of pid [#2370]

src/base/logtrace.c | 7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) Even though not being LSB it would be good to use thread id instead of process id in trace. diff --git a/src/base/logtrace.c b/src/base/logtrace.c --- a/src/base/logtrace.c +++ b/src/base/logtrace.c @@ -48,6

[devel] [PATCH 1 of 1] log: fix logd crash on Active side [#2362]

src/log/logd/lgs_filehdl.cc | 21 + 1 files changed, 13 insertions(+), 8 deletions(-) The cause of issue is free cfg_namelist while struct dirent **cfg_namelist unallocated diff --git a/src/log/logd/lgs_filehdl.cc b/src/log/logd/lgs_filehdl.cc ---

Re: [devel] [PATCH 1 of 1] CLM : Cluster reset does not succed as reboot now command fails on SLES [#2339]

Hi Ramesh, A gentle reminder for review/Thanks HansN -Original Message- From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com] Sent: den 6 mars 2017 16:28 To: ramesh.bet...@oracle.com; Anders Widell Cc: opensaf-devel@lists.sourceforge.net Subject: [devel]

Re: [devel] [PATCH 1 of 2] log: fix to remove a redundant double quotation [#1463]

Hi Can, ACK for series, not tested -AVM On 3/8/2017 6:43 PM, Canh Van Truong wrote: > src/log/logd/lgs_fmt.cc | 3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) > > > When sending a log record which is longer than limited quota, > there will be a double quotation mark although

Re: [devel] [PATCH 1 of 1] amf: print list of CLC CLI command env variables correctly [#2368]

Ack, code review only. Thanks, Praveen On 13-Mar-17 10:24 AM, Nguyen TK Luu wrote: > src/amf/amfnd/clc.cc | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > Due to a coding error, only the first env variable in the list > gets printed repeatedly for the length of the list. This

Re: [devel] [PATCH 1 of 1] base: Improve trace by using tid instead of pid [#2370]

Hi Hans N, It seems in some flavors of linux `gettid` is available, so dose it be under #ifndef ? -AVM On 3/13/2017 5:46 PM, Hans Nordeback wrote: > src/base/logtrace.c | 7 ++- > 1 files changed, 6 insertions(+), 1 deletions(-) > > > Even though not being LSB it would be good to use