Re: [devel] [PATCH 1 of 1] amfd: ignore node_up if node state is not absent [#2400]

2017-04-04 Thread praveen malviya
Ack, code review only. Thanks Praveen On 03-Apr-17 6:53 AM, Gary Lee wrote: > src/amf/amfd/ndfsm.cc | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > if a duplicate node_up is processed after cluster startup timer is finished, > don't send a reboot order > > diff --git

Re: [devel] [PATCH 0 of 1] Review Request for immm: Fixed memory leak in imm_cfg.c file [#2408]

2017-04-04 Thread Neelakanta Reddy
Hi Hung, Reviewed and tested the patch. Ack. /Neel. On 2017/04/03 10:55 AM, Hieu Nguyen wrote: > Summary: immm: Fixed memory leak in imm_cfg.c file [#2408] > Review request for Trac Ticket(s): 2408 > Peer Reviewer(s): Zoran, Neel, Hung > Pull request to: Hung > Affected branch(es): 5.0, 5.1,

[devel] [PATCH 1 of 1] imm: Check if response is NULL when sending MDS sync message [#2401]

2017-04-04 Thread Hung Nguyen
src/imm/agent/imma_mds.cc | 6 +- 1 files changed, 5 insertions(+), 1 deletions(-) Check if response is NULL when sending MDS sync message. diff --git a/src/imm/agent/imma_mds.cc b/src/imm/agent/imma_mds.cc --- a/src/imm/agent/imma_mds.cc +++ b/src/imm/agent/imma_mds.cc @@ -602,8 +602,12

[devel] [PATCH 0 of 1] Review Request for imm: Check if response is NULL when sending MDS sync message [#2401]

2017-04-04 Thread Hung Nguyen
Summary: imm: Check if response is NULL when sending MDS sync message [#2401] Review request for Trac Ticket(s): 2401 Peer Reviewer(s): Zoran, Neel Pull request to: Affected branch(es): 5.0, 5.1, 5.2, 5.3 Development branch: 5.3 Impacted area Impact y/n

[devel] [PATCH 1 of 1] amfnd: reset msg ids before sending node up [#2407]

2017-04-04 Thread Gary Lee
src/amf/amfnd/clm.cc | 1 + src/amf/amfnd/di.cc | 15 --- 2 files changed, 13 insertions(+), 3 deletions(-) if SCs are rebooted repeatedly & quickly, it is possible to receive NEW_ACTIVE without a prior DOWN event. Currently, msg ids are only reset on DOWN. Thus we should also

[devel] [PATCH 0 of 1] Review Request for amfnd: reset msg ids before sending node up [#2407]

2017-04-04 Thread Gary Lee
Summary: amfnd: reset msg ids before sending node up [#2407] Review request for Trac Ticket(s): 2407 Peer Reviewer(s): AMF devs Pull request to: <> Affected branch(es): all Development branch: default Impacted area Impact y/n

Re: [devel] [PATCH 1 of 1] log: fix log file size is not reset to zero (0) when log file is created [#1439]

2017-04-04 Thread Lennart Lund
Hi Canh Ack Thanks Lennart > -Original Message- > From: Canh Van Truong [mailto:canh.v.tru...@dektech.com.au] > Sent: den 22 mars 2017 15:56 > To: Lennart Lund ; mahesh.va...@oracle.com; > Vu Minh Nguyen > Cc: