Re: [devel] [PATCH 1/1] base: Only close inherited fd(s) after fork() in child process V2 [#2805]

Hi Anders, Please see my comments inline Thanks Minh > Ack with minor comments, marked AndersW> below. > > regards, > > Anders Widell > > > On 03/19/2018 04:36 AM, Minh Chau wrote: >> --- >> src/base/os_defs.c | 32 +++- >> 1 file changed, 27 insertions(+), 5

[devel] [PATCH 1/1] dtm: Fix the osaflog --flush command, and revert osaflog protocol [#2812]

Fix the remaining review comment for ticket [#2731]: revert back to a text-based protocol between osaflog command and osaftransportd. Also fix the osaflog --flush command, that stopped working after ticket [#2731]. --- src/dtm/common/osaflog_protocol.h | 7 - src/dtm/tools/osaflog.cc

[devel] [PATCH 0/1] Review Request for dtm: Fix the osaflog --flush command, and revert osaflog protocol [#2812]

Summary: dtm: Fix the osaflog --flush command, and revert osaflog protocol [#2812] Review request for Ticket(s): 2812 Peer Reviewer(s): Ravi Pull request to: Affected branch(es): develop Development branch: ticket-2812 Base revision: 731214ee8c95136ee7098362c87af61245938767 Personal repository:

Re: [devel] [PATCH 1/1] base: Only close inherited fd(s) after fork() in child process [#2805]

Hi Minh, I think this additional check, current and parent, directory is enough for V1 patch. The usage of the 2nd parameter of strtol in V2 patch can be put in a utility function for a broader use. /Regards HansN On 03/19/2018 08:50 AM, Minh Hon Chau wrote: Hi Hans, Agree that the

Re: [devel] [PATCH 0/1] Review Request for ntf: fix to avoid core dump of osafntfimcnd processs [#2806]

Hi Srinivas I have some comments. See attached diff Thanks Lennart > -Original Message- > From: srinivas [mailto:srinivas.mangip...@oracle.com] > Sent: den 13 mars 2018 12:45 > To: Lennart Lund ; Vu Minh Nguyen > > Cc:

Re: [devel] [PATCH 1/1] base: Only close inherited fd(s) after fork() in child process [#2805]

Hi Hans, Agree that the check of "." and ".." should be added in V1. This V2 I use the second parameter of strtol, it should ensure that anything read from the fd directory is entirely digit, before close the fd. There should not be any alphabet-based directories other than ".", ".." and 0,

Re: [devel] [PATCH 1/1] base: Only close inherited fd(s) after fork() in child process [#2805]

Hi Minh, my comment was that this check could be added: if (strcmp(pentry->d_name, ".") == 0 || strcmp(pentry->d_name, "..") == 0)    continue; /Regards HansN On 03/16/2018 01:27 PM, Minh Hon Chau wrote: Hi Anders, Hans, When I tested the patch, I did see the "." and ".." returned from

Re: [devel] [PATCH 1/1] ntfd: fix to avoid ntfimcnd from dumping core [#2806]

Hi Srinivas, Ack with some comments inline, started with [Vu]. Regards, Vu > -Original Message- > From: srinivas [mailto:srinivas.mangip...@oracle.com] > Sent: Tuesday, March 13, 2018 6:45 PM > To: lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au > Cc:

Re: [devel] [PATCH 1/1] base: Only close inherited fd(s) after fork() in child process V2 [#2805]

Ack with minor comments, marked AndersW> below. regards, Anders Widell On 03/19/2018 04:36 AM, Minh Chau wrote: --- src/base/os_defs.c | 32 +++- 1 file changed, 27 insertions(+), 5 deletions(-) diff --git a/src/base/os_defs.c b/src/base/os_defs.c index