[devel] [PATCH 1/1] mds: improve thread safety in mdstest - part 2 [#2746]

2018-03-27 Thread Hoa Le
- Remove thread-local declaration of svc_to_mds_info --- src/mds/apitest/mdstipc_api.c | 7 ++- src/mds/apitest/mdstipc_conf.c | 43 +- 2 files changed, 27 insertions(+), 23 deletions(-) diff --git a/src/mds/apitest/mdstipc_api.c

Re: [devel] [PATCH 1/1] mds: improve thread safety in mdstest - part 2 [#2746]

2018-03-27 Thread Hoa Le
Hi Hans, In version 2 of the patch, I have removed the thread-local declaration of svc_to_mds_info as your suggestion and use it as local variable for each MDS service request to avoid Data race issues. Please help review it again. Thank you. -- Best regards, Hoa Le On 03/27/2018 01:41 PM,

Re: [devel] [PATCH 1/1] mds: improve thread safety in mdstest - part 2 [#2746]

2018-03-27 Thread Hans Nordebäck
ack, review only. /Thanks HansN On 03/27/2018 10:34 AM, Hoa Le wrote: - Remove thread-local declaration of svc_to_mds_info --- src/mds/apitest/mdstipc_api.c | 7 ++- src/mds/apitest/mdstipc_conf.c | 43 +- 2 files changed, 27 insertions(+), 23

Re: [devel] [PATCH 1/1] mds: improve thread safety in mdstest - part 2 [#2746]

2018-03-27 Thread Hans Nordebäck
Hi Hoa, Do we need the svc_to_mds_info to be tls? I used it in the sample added to ticket to reduce number of helgrind warnings when I verified safe_printf and safe_fflush. It should have been removed in the sample, as it was not fully verified. /Thanks HansN -Original Message-

[devel] [PATCH 1/1] dtm: Document update for transportd.conf and osaflog options [#2820]

2018-03-27 Thread syam-talluri
modified: 00-README.conf modified: src/dtm/README --- 00-README.conf | 15 +++ src/dtm/README | 23 +++ 2 files changed, 38 insertions(+) diff --git a/00-README.conf b/00-README.conf index 94cb3d3..5f3927b 100644 --- a/00-README.conf +++

[devel] [PATCH 0/1] Review Request for dtm: Documentation update for transportd.conf and osaflog options [#2820]

2018-03-27 Thread syam-talluri
Summary: dtm: Document update for transportd.conf and osaflog options [#2820] Review request for Ticket(s): 2820 Peer Reviewer(s): anders.wid...@ericsson.com Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2820 Base revision:

[devel] [PATCH 1/1] dtm: Use base::StrToUint64 to parse command-line option arguments [#2815]

2018-03-27 Thread Anders Widell
Use the function base::StrToUint64 to pass command-line option arguments. This gives us error checking, and support for the k, M and G suffixes. --- src/dtm/tools/osaflog.cc| 44 + src/dtm/transport/log_server.cc | 44

[devel] [PATCH 0/1] Review Request for dtm: Use base::StrToUint64 to parse command-line option arguments [#2815]

2018-03-27 Thread Anders Widell
Summary: dtm: Use base::StrToUint64 to parse command-line option arguments [#2815] Review request for Ticket(s): 2815 Peer Reviewer(s): Ravi Pull request to: Affected branch(es): develop Development branch: ticket-2815 Base revision: 2e1b1228d0bb8f7aa66773f11ff915d5a39b0748 Personal repository: