Re: [devel] [PATCH 1/1] lck: fix errors when displaying SaLckResource class [#2070]

Hi Alex, Ack, code review only Regards, Ravi -Original Message- From: Alex Jones [mailto:ajo...@rbbn.com] Sent: Monday, May 07, 2018 8:13 PM To: Ravi Sekhar Reddy Konda Cc: opensaf-devel@lists.sourceforge.net; Alex Jones Subject: [PATCH

Re: [devel] [PATCH 1/1] smf: Add capability to redo CCBs that fail [#1398]

Hi Nguyen, I have added what you suggested in the new review patch almost straight off. I also found a few issues myself in SmfExecControlHdl and SmfAdminState. I have removed some class variables and functions that are no longer used. This is actually a leftover from increment 1 but I have

Re: [devel] [PATCH 1/1] smf: Add capability to redo CCBs that fail [#1398]

Hi Lennart, I've looked at your changes in the .diff file. They look good overall. - Nevertheless, I think some updates, mostly regarding comments and log/trace printouts, are needed to make the changes consistent. You can find the places to update in the attached .diff file which can be

Re: [devel] [PATCH 1/1] ntf: Don't use old style SaNameT with 255 chars DN in ntfimcnd [#2850]

Ack Thanks Lennart > -Original Message- > From: Hoa Le [mailto:hoa...@dektech.com.au] > Sent: den 14 maj 2018 11:17 > To: Minh Hon Chau ; Lennart Lund > ; srinivas.mangip...@oracle.com > Cc: opensaf-devel@lists.sourceforge.net; Hoa Le

Re: [devel] [PATCH 1/1] ntf: Don't use old style SaNameT with 255 chars DN in ntfimcnd [#2850]

Hi Hoa, Ack Thanks Minh On 14/05/18 19:17, Hoa Le wrote: osafntfimcnd uses old style SaNameT when sending notification. The SaNameT's length will be adjusted to 256 when it's value contains 255 characters excluded the NULL character. This SaNameT is now not a valid extended name and causes