[devel] [PATCH 1/1] osaf: modify log severity level in Consensus::Demote [#2912]

2018-08-16 Thread Gary Lee
All callers of Consensus::Demote() already log an error if the return code is not SA_AIS_OK. A warning message will suffice. --- src/osaf/consensus/consensus.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/osaf/consensus/consensus.cc b/src/osaf/consensus/consensus.cc in

[devel] [PATCH 0/1] Review Request for osaf: modify log severity level in Consensus::Demote [#2912]

2018-08-16 Thread Gary Lee
Summary: osaf: modify log severity level in Consensus::Demote [#2912] Review request for Ticket(s): 2912 Peer Reviewer(s): Hans, Minh, Anders Pull request to: Affected branch(es): develop Development branch: ticket-2912 Base revision: 7bcae5a2961d6b6f6c8e8930f2b7abfdd2d44329 Personal repository: gi

Re: [devel] [PATCH 1/1] osaf: modify log severity level in Consensus::Demote [#2912]

2018-08-16 Thread Minh Hon Chau
ack from me. On 17/08/18 10:00, Gary Lee wrote: > All callers of Consensus::Demote() already log an error if the return code is > not SA_AIS_OK. > A warning message will suffice. > --- > src/osaf/consensus/consensus.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src

Re: [devel] [PATCH 1/1] osaf: modify log severity level in Consensus::Demote [#2912]

2018-08-16 Thread Hans Nordebäck
Ack, (code review only)/Thanks Hans -Original Message- From: Gary Lee Sent: den 17 augusti 2018 02:00 To: Hans Nordebäck ; Minh Hon Chau ; Anders Widell Cc: opensaf-devel@lists.sourceforge.net; Gary Lee Subject: [PATCH 1/1] osaf: modify log severity level in Consensus::Demote [#2912]