[devel] [PATCH 0/3] Review Request for imm: add new test cases of apitest [#2951]

2018-11-02 Thread Mohan Kanakam
Summary: imm: add new test cases of API saImmOmClassCreate_2() of apitest [#2951] Review request for Ticket(s): 2951_1 Peer Reviewer(s):vu.m.nguyen, Hans Nordeb??ck Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2951_1 Base

[devel] [PATCH 3/3] imm: add new test case of API saImmOmClassDelete() of apitest [#2951]

2018-11-02 Thread Mohan Kanakam
--- .../apitest/management/test_saImmOmClassCreate_2.c| 4 src/imm/apitest/management/test_saImmOmClassDelete.c | 19 +++ 2 files changed, 23 insertions(+) diff --git a/src/imm/apitest/management/test_saImmOmClassCreate_2.c

[devel] [PATCH 2/3] imm: add new test case of API saImmOmClassDescriptionGet_2() of apitest [#2951]

2018-11-02 Thread Mohan Kanakam
--- .../apitest/management/test_saImmOmClassCreate_2.c | 3 +++ .../management/test_saImmOmClassDescriptionGet_2.c | 25 ++ 2 files changed, 28 insertions(+) diff --git a/src/imm/apitest/management/test_saImmOmClassCreate_2.c

[devel] [PATCH 1/3] imm: add new test cases of API saImmOmClassCreate_2() of apitest [#2951]

2018-11-02 Thread Mohan Kanakam
--- .../apitest/management/test_saImmOmClassCreate_2.c | 85 ++ 1 file changed, 85 insertions(+) diff --git a/src/imm/apitest/management/test_saImmOmClassCreate_2.c b/src/imm/apitest/management/test_saImmOmClassCreate_2.c index 4f25f8b..9afbbe7 100644 ---

Re: [devel] [PATCH 1/1] amfd: reset snd_msg_id in LostFound state [#2952]

2018-11-02 Thread Hans Nordebäck
Ack, review only/Thanks HansN Från: Gary Lee Skickat: den 2 november 2018 06:23:09 Till: nagendra @ hasolutions . in; Minh Hon Chau; Hans Nordebäck Kopia: opensaf-devel@lists.sourceforge.net; Gary Lee Ämne: [PATCH 1/1] amfd: reset snd_msg_id in LostFound state

Re: [devel] [PATCH 1/1] imm: fix coredump generated during roaming test [#2943]

2018-11-02 Thread Lennart Lund
Hi Vu, Ack. Note1: Not tested. Note2: This function is doing too much and its dependencies is very hard to understand so I cannot confirm that this will solve the problem or add any new problems within the time I can use  on this review. Thanks Lennart On tis, 2018-10-23 at 11:31 +0700, Vu

Re: [devel] [PATCH 1/1] mds: Send NCSMDS_DOWN with vdest if there is no any adest [#2941]

2018-11-02 Thread Hans Nordebäck
Hi Minh, ack, code review and mdstest run. One minor comment below. /Thanks HansN On 10/25/18 04:40, Minh Chau wrote: > If split brain happens and network merges back, at this point in time > there are a few mds events coming to payloads, which are the SVC UP > from the other controller; SVC