[devel] [PATCH 0/1] Review Request for ntf: Increase the priority when sending MDS_DOWN to NTFD maind thread [#2973]

2018-11-27 Thread Canh Van Truong
Summary: ntf: Increase the priority when sending MDS_DOWN to NTFD maind thread [#2973] Review request for Ticket(s): 2973 Peer Reviewer(s): Lennart, Minh Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2973 Base revision: 8c5f9

[devel] [PATCH 1/1] ntf: Increase the priority when sending MDS_DOWN to NTFD maind thread [#2973]

2018-11-27 Thread Canh Van Truong
When the sending notification request come to NTFD , they are put in the mbx to wait for being processed. if client of these request is down, MDS thread receive the event down and also put to mbx. The priority of event down and send request are the same. So NTF will process the send request before

Re: [devel] [PATCH 1/1] ntf: Increase the priority when sending MDS_DOWN to NTFD maind thread [#2973]

2018-11-27 Thread Lennart Lund
Hi Canh, Ack, with comments see [Lennart] below. I have not tested I cannot say if this is a good solution or not. Thanks Lennart -Original Message- From: Canh Van Truong Sent: den 27 november 2018 14:17 To: Lennart Lund ; Minh Hon Chau Cc: opensaf-devel@lists.sourceforge.net; Canh V

Re: [devel] [PATCH 1/1] ntf: Increase the priority when sending MDS_DOWN to NTFD maind thread [#2973]

2018-11-27 Thread Canh Van Truong
Thanks Lennart, Yes, I sent with wrong patch. This patch was including my testing. The solution just increases the priority when sending the MDS_DOWN event. I am sending the right. Regards Canh -Original Message- From: Lennart Lund Sent: Tuesday, November 27, 2018 10:40 PM To: Canh

Re: [devel] [PATCH 1/1] ntf: Increase the priority when sending MDS_DOWN to NTFD maind thread [#2973]

2018-11-27 Thread Tran Thuan
Hi Canh, I just wonder if any notification miss cause by this change? Example: Agent send notification then it terminate. Will NTFD handle Agent DOWN then skip notification already received from Agent? Also, what is the problem/consequence of current behavior? Is ticket a defect or an enhance

Re: [devel] [PATCH 1/1] ntf: Increase the priority when sending MDS_DOWN to NTFD maind thread [#2973]

2018-11-27 Thread Canh Van Truong
Hi aThuan NTFD just prioritize to handle the MDS_DOWN first. The notification will be handled later and will be logged to log file. The ticket is defect ticket. I updated the ticket a little bit. Regards Canh -Original Message- From: Tran Thuan Sent: Wednesday, November 28, 2018 10:39

[devel] [PATCH 0/1] Review Request for ntf: Increase the priority when sending MDS_DOWN to NTFD maind thread V2 [#2973]

2018-11-27 Thread Canh Van Truong
Summary: ntf: Increase the priority when sending MDS_DOWN to NTFD maind thread [#2973] Review request for Ticket(s): 2973 Peer Reviewer(s): Lennart, Minh Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2973 Base revision: 8c5f9

[devel] [PATCH 1/1] ntf: Increase the priority when sending MDS_DOWN to NTFD maind thread [#2973]

2018-11-27 Thread Canh Van Truong
When the sending notification request come to NTFD , they are put in the mbx to wait for being processed. if client of these request is down, MDS thread receive the event down and also put to mbx. The priority of event down and send request are the same. So NTF will process the send request before