Re: [devel] [PATCH 1/1] mds: support multicast fragmented messages [#3033]

2019-04-25 Thread Tran Thuan
Hi bro.Vu, Thanks for comments. Seems they are not really matter change or not, can we keep current patch? Then we don't need push another PS for adaption patch in our repo. Best Regards, ThuanTr -Original Message- From: Vu Minh Nguyen Sent: Thursday, April 25, 2019 1:51 PM To:

Re: [devel] [PATCH 1/1] mds: support multicast fragmented messages [#3033]

2019-04-25 Thread Vu Minh Nguyen
Hi Thuan, Ack with minor comments below. Regards, Vu > -Original Message- > From: thuan.tran > Sent: Wednesday, April 24, 2019 6:06 PM > To: 'Vu Minh Nguyen' ; > hans.nordeb...@ericsson.com; Minh Hon Chau > > Cc: opensaf-devel@lists.sourceforge.net; thuan.tran > > Subject: [PATCH

Re: [devel] [PATCH 0/1] Review Request for mds: support multicast fragmented messages [#3033] V3

2019-04-25 Thread Hans Nordebäck
Hi Vu, you are right, my concern was the description of the problem, and it looks ok with your explanation. /Thanks Hans On 2019-04-25 13:33, Vu Minh Nguyen wrote: > Hi Hans, > > Probably you were looking at code that included this Thuan's patch. > > In legacy code, only mdtm_sendto() is called

Re: [devel] [PATCH 0/1] Review Request for mds: support multicast fragmented messages [#3033] V3

2019-04-25 Thread Hans Nordebäck
Hi Vu and Thuan, a few question, is the text in the ticket description correct? E.g it says unicast is used if a multicast message is fragmented, (I think multicast still is used to send the fragments), this is what you mean with 2 different channels? (only one socket is used, BSRsock), The

Re: [devel] [PATCH 0/1] Review Request for mds: support multicast fragmented messages [#3033] V3

2019-04-25 Thread Hans Nordebäck
Hi Vu, It seems mdtm_mcast_sendto is used in mdtm_frag_and_send, at MDS_SENDTYPE_BCAST/BR Hans -Original Message- From: Vu Minh Nguyen Sent: den 25 april 2019 12:20 To: Hans Nordebäck ; Thuan Tran ; Minh Hon Chau Cc: opensaf-devel@lists.sourceforge.net Subject: RE: [PATCH 0/1]

Re: [devel] [PATCH 0/1] Review Request for mds: support multicast fragmented messages [#3033] V3

2019-04-25 Thread Vu Minh Nguyen
Hi Hans, Probably you were looking at code that included this Thuan's patch. In legacy code, only mdtm_sendto() is called inside the function mdtm_frag_and_send(). Regards, Vu > -Original Message- > From: Hans Nordebäck > Sent: Thursday, April 25, 2019 6:10 PM > To: Vu Minh Nguyen ;

Re: [devel] [PATCH 0/1] Review Request for mds: support multicast fragmented messages [#3033] V3

2019-04-25 Thread Vu Minh Nguyen
Hi Hans, See my responses inline. Regards, Vu > -Original Message- > From: Hans Nordebäck > Sent: Thursday, April 25, 2019 4:28 PM > To: Thuan Tran ; Vu Minh Nguyen > ; Minh Hon Chau > > Cc: opensaf-devel@lists.sourceforge.net > Subject: Re: [PATCH 0/1] Review Request for mds: support