Re: [devel] [PATCH 6/9] mds: Implement kRcvBuffOverflow state [#1960]

Hi Minh, I has few comments below. Regards, Vu On 8/14/19 1:38 PM, Minh Chau wrote: This patch implements the kRcvBuffOverflow state machine as described in README file. --- src/mds/mds_tipc_fctrl_intf.cc | 6 +- src/mds/mds_tipc_fctrl_msg.h | 1 + src/mds/mds_tipc_fctrl_portid.c

Re: [devel] [PATCH 1/9] mds: Add README for solution of TIPC buffer overflow at MDS [#1960]

Hi Minh, I have just finished my review to your MDS patches, and I have a question: With 2N services, suppose the active is having TIPC overloaded issue; it will do some memory allocations, and probably starting a timer there too. Then, what happens if that active service is changed to the st

Re: [devel] [PATCH 1/9] mds: Add README for solution of TIPC buffer overflow at MDS [#1960]

Hi Vu, Thanks for your time to review the patches, the question is interesting. At this moment with normal load traffic, the resource towards the new standby (old active) is not released and will be reused if standby switches back to active. The reason is that mds won't start the "tx probatio

Re: [devel] [PATCH 6/9] mds: Implement kRcvBuffOverflow state [#1960]

Hi Vu, Agree with your comments. Any comments for patches 8/9 and 9/9? thanks Minh On 16/9/19 5:22 pm, Nguyen Minh Vu wrote: Hi Minh, I has few comments below. Regards, Vu On 8/14/19 1:38 PM, Minh Chau wrote: This patch implements the kRcvBuffOverflow state machine as described in README

Re: [devel] [PATCH 1/1] amfd: correct handling complete/apply callback on standby sc [#3082]

Hi Thang ack (review only) Thanks Gary On 16/9/19 4:44 pm, thang.d.nguyen wrote: During stanby SC comes up, AMF config objects are deleted on active SC. It causes NOT_EXIST error on standby node. AMFD on standby should ignore this error in this case. --- src/amf/amfd/app.cc| 29

Re: [devel] [PATCH 8/9] mds: Apply serial number arithmetic for sequence counter [#1960]

Hi Minh, I have a minor comment below. Regards, Vu On 8/14/19 1:38 PM, Minh Chau wrote: This patch applies the serial number arithmetic for the flow control sequence number, referenced to RFC1982. This is only temporary patch, a proper one could be made in /base with template for others type,

Re: [devel] [PATCH 8/9] mds: Apply serial number arithmetic for sequence counter [#1960]

Hi Vu, Agree with your suggestion, it will be done in #3074. Thanks Minh On 17/9/19 1:39 pm, Nguyen Minh Vu wrote: Hi Minh, I have a minor comment below. Regards, Vu On 8/14/19 1:38 PM, Minh Chau wrote: This patch applies the serial number arithmetic for the flow control sequence number,

Re: [devel] [PATCH 1/1] amf: handle errors identified by codechecker [#3077]

Hi Gary, ack from me (code review only) Thanks Minh On 3/9/19 12:12 pm, Gary Lee wrote: add assertions where pointers should not be null fix a couple of typos --- src/amf/amfd/comp.cc | 1 + src/amf/amfd/csi.cc| 3 ++- src/amf/amfd/cstype.cc | 2 ++ src/a