[devel] [PATCH 1/1] mds: Enhance decoding for mds flow control message [#3097]

2019-10-06 Thread Minh Chau
mds currently uses MDS_PROT_FCTRL_ID 4 bytes value (0x00AC13F5) from octet11 to octet14 to identify the flow control message e.g., chunkack message. In case of fragmentation from big message, the second fragment onwards will start from the octet11, which may have arbitrary value and cause mds to in

[devel] [PATCH 0/1] Review Request for mds: Enhance decoding for mds flow control message [#3097]

2019-10-06 Thread Minh Chau
Summary: mds: Enhance decoding for mds flow control message [#3097] Review request for Ticket(s): 3097 Peer Reviewer(s): Hans, Vu, Gary, Thuan Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-3097 Base revision: e699c22ddc1ca8530

Re: [devel] [PATCH 0/2] Review Request for mds: Add Nack message for MDS_TIPC_FCTRL_ENABLED [#3095] V2

2019-10-06 Thread Minh Hon Chau
Hi, I would like to push the patches today if no more comment for them. Thanks Minh On 4/10/19 3:20 pm, Minh Chau wrote: Summary: mds: Add Nack message for MDS_TIPC_FCTRL_ENABLED [#3095] V2 Review request for Ticket(s): 3095 Peer Reviewer(s): Hans, Vu, Gary, Thuan Pull request to: *** LIST TH

Re: [devel] [PATCH 1/1] amf: add asserts to problematic areas identified by codechecker [#3077]

2019-10-06 Thread Tran Thuan
Hi Gary, ACK from me. Best Regards, ThuanTr -Original Message- From: Gary Lee Sent: Thursday, October 3, 2019 12:11 PM To: thuan.t...@dektech.com.au; minh.c...@dektech.com.au; hans.nordeb...@ericsson.com Cc: opensaf-devel@lists.sourceforge.net; Gary Lee Subject: [PATCH 1/1] amf: add a

[devel] [PATCH 1/1] ntfd: Do not send response to client if client down [#3084]

2019-10-06 Thread thien.m.huynh
Ntfd will not send response to a client when client already down. This will avoid timeout when ntfd send via mds. --- src/ntf/ntfd/NtfAdmin.cc | 61 src/ntf/ntfd/NtfAdmin.h | 1 + src/ntf/ntfd/ntfs_cb.h | 6 + src/ntf/ntfd/ntfs_com.c | 4

[devel] [PATCH 0/1] Review Request for ntfd: Do not send response to client if client down V2 [#3084]

2019-10-06 Thread thien.m.huynh
Summary: ntfd: Do not send response to client if client down [#3083] Review request for Ticket(s): 3084 Peer Reviewer(s): Vu, Minh Pull request to: Vu Affected branch(es): develop Development branch: ticket-3084 Base revision: e699c22ddc1ca8530318b0dc0bde46794a224bd9 Personal repository: git://git.

Re: [devel] [PATCH 1/1] mds: Enhance decoding for mds flow control message [#3097]

2019-10-06 Thread Tran Thuan
Hi Minh, Some minor comments from me, check [Thuan] inline. Thanks. Best Regards, ThuanTr -Original Message- From: Minh Chau Sent: Monday, October 7, 2019 7:12 AM To: hans.nordeb...@ericsson.com; vu.m.ngu...@dektech.com.au; gary@dektech.com.au; thuan.t...@dektech.com.au Cc: opensaf

Re: [devel] [PATCH 1/1] mds: Enhance decoding for mds flow control message [#3097]

2019-10-06 Thread Minh Hon Chau
Hi Thuan, Please see comments inline. Thanks Minh On 7/10/19 3:18 pm, Tran Thuan wrote: Hi Minh, Some minor comments from me, check [Thuan] inline. Thanks. Best Regards, ThuanTr -Original Message- From: Minh Chau Sent: Monday, October 7, 2019 7:12 AM To: hans.nordeb...@ericsson.co

Re: [devel] [PATCH 0/2] Review Request for mds: Add Nack message for MDS_TIPC_FCTRL_ENABLED [#3095] V2

2019-10-06 Thread Tran Thuan
Hi Minh, ACK from me. Best Regards, ThuanTr -Original Message- From: Minh Hon Chau Sent: Monday, October 7, 2019 7:12 AM To: hans.nordeb...@ericsson.com; vu.m.ngu...@dektech.com.au; gary@dektech.com.au; thuan.t...@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net Subject: Re: