Hi Thuan,
Please see comment inline
Thanks
Minh
On 13/11/19 2:24 pm, Tran Thuan wrote:
Hi Minh,
Please check replies inline. Thanks.
Best Regards,
ThuanTr
-Original Message-
From: Minh Hon Chau
Sent: Wednesday, November 13, 2019 10:05 AM
To: Tran Thuan ; 'Nguyen Minh Vu'
;
Hi Thuan,
Please see comment inline.
Thanks
Minh
On 13/11/19 1:11 pm, Tran Thuan wrote:
Hi Minh,
Thanks for comments, please check my replies inline.
Best Regards,
ThuanTr
-Original Message-
From: Minh Hon Chau
Sent: Wednesday, November 13, 2019 7:47 AM
To: thuan.tran ; 'Nguyen
Hi Minh,
Please check replies inline. Thanks.
Best Regards,
ThuanTr
-Original Message-
From: Minh Hon Chau
Sent: Wednesday, November 13, 2019 10:05 AM
To: Tran Thuan ; 'Nguyen Minh Vu'
; gary@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] mds: fix
Summary: osaf: return a help message if no parameter is specified [#3118]
Review request for Ticket(s): 3118
Peer Reviewer(s): Minh, Thuan
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-3118
Base revision:
---
src/osaf/consensus/plugins/tcp/tcp.plugin | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/osaf/consensus/plugins/tcp/tcp.plugin
b/src/osaf/consensus/plugins/tcp/tcp.plugin
index 1b5ddf5..0be20fc 100755
--- a/src/osaf/consensus/plugins/tcp/tcp.plugin
+++
Hi Thuan,
Some comments inline.
Thanks
Minh
On 12/11/19 5:04 pm, thuan.tran wrote:
When overload happens, sender will wait for chunkAck to continue
sending more messages, it should send number of message equal chunkAck
size of receiver. If not, receiver don't receive enough messages to send
Hi Minh,
Thanks for comments, please check my replies inline.
Best Regards,
ThuanTr
-Original Message-
From: Minh Hon Chau
Sent: Wednesday, November 13, 2019 7:47 AM
To: thuan.tran ; 'Nguyen Minh Vu'
; gary@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re:
Hi,
Any comments on the patches? Otherwise I wish to push them in the next
day or two.
Thanks
Minh
On 8/11/19 9:33 pm, Minh Chau wrote:
Summary: mds: Distinguish protocol version of fragment [#3111]
Review request for Ticket(s): 3111
Peer Reviewer(s): Gary, Vu, Thuan
Pull request to: ***