Hi Minh,
ACK from me.
Best Regards,
ThuanTr
-Original Message-
From: Minh Chau
Sent: Monday, November 25, 2019 7:53 AM
To: thuan.t...@dektech.com.au; vu.m.ngu...@dektech.com.au;
gary@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net; Minh Chau
Subject: [PATCH 1/1] mds:
Hi Vu,
ACK from me (code review).
Best Regards,
ThuanTr
-Original Message-
From: Vu Minh Nguyen
Sent: Monday, November 25, 2019 1:45 PM
To: thuan.t...@dektech.com.au; thien.m.hu...@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net; Vu Minh Nguyen
Subject: [PATCH 1/1] nid: fix
Hi Minh,
Ack with comments inline.
Regards, Vu
On 11/25/19 1:12 PM, Minh Chau wrote:
The patch avoids message reallocation if enable
MDS_TIPC_FCTRL_ENABLED
---
src/mds/mds_dt_tipc.c| 27 ---
src/mds/mds_tipc_fctrl_msg.cc| 2 +-
Summary: nid: fix unable to start UML cluster with tipc transport [#3122]
Review request for Ticket(s): 3122
Peer Reviewer(s): Thuan, Thien
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-3122
Base revision:
---
src/nid/configure_tipc.in | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/src/nid/configure_tipc.in b/src/nid/configure_tipc.in
index a63c97046..43ddb06e1 100644
--- a/src/nid/configure_tipc.in
+++ b/src/nid/configure_tipc.in
@@ -221,11 +221,13 @@ function
Summary: mds: Avoid message re-allocation [#3089]
Review request for Ticket(s): 3089
Peer Reviewer(s): Thuan, Gary, Vu
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-3089
Base revision: c6c7e77292d622ee042476bb0815feae51dd0cba
The patch avoids message reallocation if enable
MDS_TIPC_FCTRL_ENABLED
---
src/mds/mds_dt_tipc.c| 27 ---
src/mds/mds_tipc_fctrl_msg.cc| 2 +-
src/mds/mds_tipc_fctrl_portid.cc | 9 +++--
3 files changed, 24 insertions(+), 14 deletions(-)
diff --git
Hi Minh,
ACK from me.
Best Regards,
ThuanTr
-Original Message-
From: Minh Chau
Sent: Monday, November 25, 2019 1:13 PM
To: thuan.t...@dektech.com.au; gary@dektech.com.au;
vu.m.ngu...@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net; Minh Chau
Subject: [PATCH 1/1] mds:
Summary: amfd: not accept lock-in admin op if presence msg not processed [#3121]
Review request for Ticket(s): 3121
Peer Reviewer(s): Gary,Minh,Thuan
Pull request to: Thuan
Affected branch(es): develop
Development branch: ticket-3121
Base revision: c6c7e77292d622ee042476bb0815feae51dd0cba
Personal
AMFD should not accept lock-in admin op on SU if the presence msg
has already sent to that SU.
---
src/amf/amfd/sgproc.cc | 1 +
src/amf/amfd/su.cc | 13 +
src/amf/amfd/su.h | 2 ++
3 files changed, 16 insertions(+)
diff --git a/src/amf/amfd/sgproc.cc
Hi Vu,
Sorry, I have comments inline.
Best Regards,
ThuanTr
-Original Message-
From: Tran Thuan
Sent: Monday, November 25, 2019 2:27 PM
To: 'Vu Minh Nguyen' ;
'thien.m.hu...@dektech.com.au'
Cc: 'opensaf-devel@lists.sourceforge.net'
Subject: RE: [PATCH 1/1] nid: fix unable to start
The logging of broadcast/multicast is currently logged with
NOTIFY as mds does not support broadcast/multicast message,
so the logging would be helpful in some cases. However, the
mds.log may be located in nfs file system, and this logging
may cause high rate traffic towards nfs file system.
This
Summary: mds: Reduce mds logging [#3120]
Review request for Ticket(s): 3120
Peer Reviewer(s): Thuan, Vu, Gary
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-3120
Base revision: c6c7e77292d622ee042476bb0815feae51dd0cba
Personal
13 matches
Mail list logo
