[devel] [PATCH 1/1] base: add serial number arithmetic (RFC1982) [#3074]

2020-02-12 Thread thuan.tran
- Adapt MDS with this SNA implementation. --- src/base/Makefile.am | 6 +- src/base/sna.h | 136 +++ src/base/tests/sna_test.cc | 117 ++ src/mds/mds_tipc_fctrl_intf.cc | 2 +- src/mds/mds_tipc_fctrl_port

[devel] [PATCH 0/1] Review Request for base: add serial number arithmetic (RFC1982) [#3074]

2020-02-12 Thread thuan.tran
Summary: base: add serial number arithmetic (RFC1982) [#3074] Review request for Ticket(s): 3074 Peer Reviewer(s): Minh, Thang, Vu, Gary Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-3074 Base revision: 09604b503698a6257272668

[devel] [PATCH 0/1] Review Request for mds: fix memleak in agent enable flow control [#3151]

2020-02-12 Thread thuan.tran
Summary: mds: fix memleak in agent enable flow control [#3151] Review request for Ticket(s): 3151 Peer Reviewer(s): Minh, Thang, Vu, Gary Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-3151 Base revision: 09604b503698a625727266

[devel] [PATCH 1/1] mds: fix memleak in agent enable flow control [#3151]

2020-02-12 Thread thuan.tran
Agent enable flow control keep add new portid without remove. Remove portid when svc count become zero then handle portid reset properly, peer A may see portid reset (peer B) then peer B should accept fseq(1) message from peer A. --- src/mds/mds_tipc_fctrl_intf.cc | 6 ++ src/mds/mds_tipc_f

Re: [devel] [PATCH 1/1] mds: fix memleak in agent enable flow control [#3151]

2020-02-12 Thread Minh Hon Chau
Hi Thuan, Ack from me. Thanks Minh On 12/2/20 9:29 pm, thuan.tran wrote: Agent enable flow control keep add new portid without remove. Remove portid when svc count become zero then handle portid reset properly, peer A may see portid reset (peer B) then peer B should accept fseq(1) message fro