[devel] [PATCH 2/2] imma: Correctly use IMMA_SYNCR_TIMEOUT [#3260]

--- src/imm/agent/imma_oi_api.cc | 2 +- src/imm/agent/imma_om_api.cc | 2 +- src/imm/agent/imma_proc.cc | 5 +++-- src/imm/immd/immd_cb.h | 1 - 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/imm/agent/imma_oi_api.cc b/src/imm/agent/imma_oi_api.cc index

[devel] [PATCH 0/2] Review Request for immnd: Make IMMSV_FEVS_MAX_PENDING environment variable [#3260] V2

Summary: immnd: Make IMMSV_FEVS_MAX_PENDING environment variable [#3260] V2 Review request for Ticket(s): 3260 Peer Reviewer(s): Thien, Surbhi, Thang Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-3260 Base revision:

[devel] [PATCH 1/2] immnd: Make IMMSV_FEVS_MAX_PENDING environment variable [#3260]

Immnd allows IMMSV_FEVS_MAX_PENDING sourced from enviroment variable, or uses default value (16) otherwise --- src/imm/common/immsv_api.h | 4 src/imm/immloadd/imm_loader.cc | 2 +- src/imm/immnd/ImmModel.cc | 2 +- src/imm/immnd/immnd.conf | 4

Re: [devel] [PATCH 0/2] Review Request for immnd: Make IMMSV_FEVS_MAX_PENDING environment variable [#3260]

Thank you Thien, V2 is out. /Minh On 14/5/21 7:05 pm, Thien Minh Huynh wrote: Hi Minh, ACK from me with minor comments. IMMSV_DEFAULT_FEVS_MAX_PENDING has been removed in this patch. I think you should grep "IMMSV_DEFAULT_FEVS_MAX_PENDING" and change it accordingly.

Re: [devel] [PATCH 1/2] immnd: Make IMMSV_FEVS_MAX_PENDING environment variable [#3260]

Hi Minh, 2 comments inline. B.R/Thang -Original Message- From: Minh Hon Chau Sent: Tuesday, May 18, 2021 6:51 AM To: Thien Minh Huynh ; Surbhi Tripathi ; Thang Duc Nguyen Cc: opensaf-devel@lists.sourceforge.net; Minh Hon Chau Subject: [PATCH 1/2] immnd: Make IMMSV_FEVS_MAX_PENDING

[devel] [PATCH 1/1] smf: enhance smf to handle timeout in one step upgrade [#3262]

In one step upgrade, during the lock nodegroup. The timeout can happen and it causes the upgrade failed. By retrying if the return code of saImmOmAdminOperationInvoke_2() is SA_AIS_ERR_NO_OP, the lock is considered as successfully. --- src/smf/smfd/SmfAdminState.cc | 13 - 1 file

[devel] [PATCH 0/1] Review Request for smf: enhance smf to handle timeout in one step upgrade [#3262] V2

Summary: smf: enhance smf to handle timeout in one step upgrade [#3262] Review request for Ticket(s): 3262 Peer Reviewer(s): Thanh, Minh Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-3262 Base revision:

Re: [devel] [PATCH 1/2] immnd: Make IMMSV_FEVS_MAX_PENDING environment variable [#3260]

Hi Minh, One more. B.R/Thang -Original Message- From: Minh Hon Chau Sent: Tuesday, May 18, 2021 9:36 AM To: Thang Duc Nguyen ; Thien Minh Huynh ; Surbhi Tripathi Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [PATCH 1/2] immnd: Make IMMSV_FEVS_MAX_PENDING environment variable

[devel] [PATCH 0/1] Review Request for smf: enhance smf to handle timeout in one step upgrade [#3262] V3

Summary: smf: enhance smf to handle timeout in one step upgrade [#3262] Review request for Ticket(s): 3262 Peer Reviewer(s): Thanh, Minh Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-3262 Base revision:

[devel] [PATCH 1/1] smf: enhance smf to handle timeout in one step upgrade [#3262]

In one step upgrade, during the lock nodegroup. The timeout can happen and it causes the upgrade failed. By retrying if the return code of saImmOmAdminOperationInvoke_2() is SA_AIS_ERR_NO_OP, the lock is considered as successfully. --- src/smf/smfd/SmfAdminState.cc | 12 1 file

Re: [devel] [PATCH 1/1] smf: enhance smf to handle timeout in one step upgrade [#3262]

Hi Thang, Ack with V3. Thanks Minh On 18/5/21 1:53 pm, thang.d.nguyen wrote: In one step upgrade, during the lock nodegroup. The timeout can happen and it causes the upgrade failed. By retrying if the return code of saImmOmAdminOperationInvoke_2() is SA_AIS_ERR_NO_OP, the lock is considered

Re: [devel] [PATCH 1/2] immnd: Make IMMSV_FEVS_MAX_PENDING environment variable [#3260]

Hi Thang, Please see inline comments Thanks Minh On 18/5/21 12:28 pm, Thang Duc Nguyen wrote: Hi Minh, 2 comments inline. B.R/Thang -Original Message- From: Minh Hon Chau Sent: Tuesday, May 18, 2021 6:51 AM To: Thien Minh Huynh ; Surbhi Tripathi ; Thang Duc Nguyen Cc:

Re: [devel] [PATCH 1/1] smf: enhance smf to handle timeout in one step upgrade [#3262]

Hi Minh, Good catch. I will update in V3. -Original Message- From: Minh Hon Chau Sent: Tuesday, May 18, 2021 9:44 AM To: Thang Duc Nguyen ; Thanh Nguyen Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [PATCH 1/1] smf: enhance smf to handle timeout in one step upgrade [#3262]

Re: [devel] [PATCH 1/1] smf: enhance smf to handle timeout in one step upgrade [#3262]

Hi Thang, Please see comment inline. Thanks Minh On 18/5/21 12:37 pm, thang.d.nguyen wrote: In one step upgrade, during the lock nodegroup. The timeout can happen and it causes the upgrade failed. By retrying if the return code of saImmOmAdminOperationInvoke_2() is SA_AIS_ERR_NO_OP, the lock

Re: [devel] [PATCH 1/2] immnd: Make IMMSV_FEVS_MAX_PENDING environment variable [#3260]

Hi Thang, Please see reply. Thanks Minh On 18/5/21 12:42 pm, Thang Duc Nguyen wrote: Hi Minh, One more. B.R/Thang -Original Message- From: Minh Hon Chau Sent: Tuesday, May 18, 2021 9:36 AM To: Thang Duc Nguyen ; Thien Minh Huynh ; Surbhi Tripathi Cc:

Re: [devel] [PATCH 1/2] immnd: Make IMMSV_FEVS_MAX_PENDING environment variable [#3260]

OK. No more comment. -Original Message- From: Minh Hon Chau Sent: Tuesday, May 18, 2021 9:47 AM To: Thang Duc Nguyen ; Thien Minh Huynh ; Surbhi Tripathi Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [PATCH 1/2] immnd: Make IMMSV_FEVS_MAX_PENDING environment variable [#3260]

Re: [devel] [PATCH 2/2] imma: Correctly use IMMA_SYNCR_TIMEOUT [#3260]

Ack. -Original Message- From: Minh Hon Chau Sent: Wednesday, May 12, 2021 7:58 AM To: Thien Minh Huynh ; Surbhi Tripathi ; Thang Duc Nguyen Cc: opensaf-devel@lists.sourceforge.net; Minh Hon Chau Subject: [PATCH 2/2] imma: Correctly use IMMA_SYNCR_TIMEOUT [#3260] ---