osaf/services/saf/amf/amfnd/di.cc | 5 -
osaf/services/saf/amf/amfnd/hcdb.cc | 3 +--
osaf/services/saf/amf/amfnd/main.cc | 2 +-
osaf/services/saf/amf/amfnd/pg.cc | 5 ++---
osaf/services/saf/amf/amfnd/sidb.cc | 12 +++-
osaf/services/saf/amf/amfnd/sudb.cc | 4 ++--
osa
osaf/services/saf/amf/amfnd/main.cc | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
* Calling risky function (SECURE_CODING)
fix buffer overflow if a string longer than 31 chars is specified for
"node_type"
diff --git a/osaf/services/saf/amf/amfnd/main.cc
b/osaf/services/saf/amf/
osaf/services/saf/amf/amfnd/comp.cc | 16 ++--
osaf/services/saf/amf/amfnd/compdb.cc | 20 +---
2 files changed, 15 insertions(+), 21 deletions(-)
* Dereference after null check (FORWARD_NULL)
* Logically dead code (DEADCODE)
* Uninitialized scalar variable (UNINI
osaf/services/saf/amf/amfd/util.cc | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
* use delete[] for variables allocated with new[]
diff --git a/osaf/services/saf/amf/amfd/util.cc
b/osaf/services/saf/amf/amfd/util.cc
--- a/osaf/services/saf/amf/amfd/util.cc
+++ b/osaf/services/saf
osaf/services/saf/amf/amfd/compcstype.cc | 5 +++--
osaf/services/saf/amf/amfd/hlt.cc| 2 +-
osaf/services/saf/amf/amfd/imm.cc| 9 ++---
3 files changed, 10 insertions(+), 6 deletions(-)
* Calling risky function (SECURE_CODING)
replace calls to sprintf with snprintf
diff
osaf/services/saf/amf/amfd/app.cc | 27 ---
osaf/services/saf/amf/amfd/apptype.cc | 13 -
2 files changed, 16 insertions(+), 24 deletions(-)
* Unnecessary header file (HFA)
* Logically dead code (DEADCODE)
* Dereference null return value (NULL_RETURNS)
*
osaf/services/saf/amf/amfnd/cbq.cc | 13 ++---
osaf/services/saf/amf/amfnd/chc.cc | 10 +++---
2 files changed, 17 insertions(+), 6 deletions(-)
* Unchecked return value (CHECKED_RETURN)
* Logically dead code (DEADCODE)
* Dereference null return value (NULL_RETURNS)
diff --git a/o
osaf/services/saf/amf/amfnd/ckpt_updt.cc | 4 ++--
osaf/services/saf/amf/amfnd/compdb.cc| 6 +++---
osaf/services/saf/amf/amfnd/sidb.cc | 2 +-
3 files changed, 6 insertions(+), 6 deletions(-)
* use delete[] for variables allocated with new[]
diff --git a/osaf/services/saf/amf/amfnd
osaf/services/saf/amf/amfnd/clc.cc | 11 ---
osaf/services/saf/amf/amfnd/clm.cc | 11 ++-
2 files changed, 10 insertions(+), 12 deletions(-)
* Unnecessary header file (HFA)
* Unchecked return value (CHECKED_RETURN)
* Uninitialized scalar variable (UNINIT)
* Out-of-bounds read (
osaf/services/saf/amf/amfd/hlt.cc | 1 +
osaf/services/saf/amf/amfd/imm.cc | 1 +
osaf/services/saf/amf/amfd/include/ntf.h | 4 ++--
osaf/services/saf/amf/amfd/include/sg.h | 1 -
osaf/services/saf/amf/amfd/include/susi.h | 4 ++--
5 files changed, 6 insertions(+), 5 deleti
osaf/services/saf/amf/amfd/su.cc | 14 --
osaf/services/saf/amf/amfd/sutcomptype.cc| 4 +++-
osaf/services/saf/amf/amfd/sutype.cc | 12 +---
osaf/services/saf/amf/amfd/svctype.cc| 6 +++---
osaf/services/saf/amf/amfd/svctypecstypes.cc | 6
osaf/services/saf/amf/amfd/role.cc | 6 +-
osaf/services/saf/amf/amfd/sg.cc | 24 ++--
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 1 +
osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 12
osaf/services/saf/amf/amfd/sg_npm_fsm.cc
osaf/services/saf/amf/amfd/cluster.cc| 3 +--
osaf/services/saf/amf/amfd/comp.cc | 17 ++---
osaf/services/saf/amf/amfd/compcstype.cc | 5 +
osaf/services/saf/amf/amfd/comptype.cc | 7 +--
osaf/services/saf/amf/amfd/csi.cc| 20 ++--
o
Summary: AMF: Coverity issues in amfd/amfnd [#680]
Review request for Trac Ticket(s): 680
Peer Reviewer(s): Hans N, Hans F, Praveen, Nagendra
Pull request to:
Affected branch(es): default
Development branch: default
Impacted area Impact y/n
osaf/services/saf/amf/amfd/ndfsm.cc| 4 +++-
osaf/services/saf/amf/amfd/ndproc.cc | 5 -
osaf/services/saf/amf/amfd/node.cc | 12
osaf/services/saf/amf/amfd/nodegroup.cc| 18 +++---
osaf/services/saf/amf/amfd/nodeswbundle.cc | 2 +-
os
osaf/services/saf/amf/amfd/si.cc | 24
osaf/services/saf/amf/amfd/si_dep.cc | 11 ---
osaf/services/saf/amf/amfd/siass.cc | 4 ++--
osaf/services/saf/amf/amfd/sirankedsu.cc | 15 ---
4 files changed, 30 insertions(+), 24 deletions(
osaf/tools/safimm/immcfg/imm_cfg.c | 36 +++-
1 files changed, 19 insertions(+), 17 deletions(-)
Fix RDN value with a DN of an associated object when a new object is created by
immcfg.
diff --git a/osaf/tools/safimm/immcfg/imm_cfg.c
b/osaf/tools/safimm/immcfg/
Summary: IMMTOOLS: fix RDN value with a DN of an associated object in immcfg
[#702]
Review request for Trac Ticket(s): 702
Peer Reviewer(s): Neelakanta
Pull request to: Zoran
Affected branch(es): opensaf-4.2.x, opensaf-4.3.x, default(4.4)
Development branch: default(4.4)
-
ACK with following comments, fix them before pushing :
1) nodeAddress family is not matching with Saf values (SA_CLM_AF_INET /
SA_CLM_AF_INET6, CLM nodeAddress family is getting papulated with
AF_INET/AF_INET6 , please correct it .
19 matches
Mail list logo